Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 145513004: Fix the 17px dead region in the bottom right corner of top level browser windows. (Closed)

Created:
6 years, 10 months ago by ananta
Modified:
6 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Fix the 17px dead region in the bottom right corner of top level browser windows. This is a sideeffect of the fake WS_VSCROLL and WS_HSCROLL styles added to the window and us hiding the scrollbars during sizing operations. Bug does not exist on Windows 8. On Windows 7 hovering near the bottom right portion of the window where the vertical scrollbar would be returns HTBOTTOMRIGHT instead of HTVSCROLL or HTHSCROLL which we already handle. This eventually results in non client mouse messages like WM_NCMOUSEMOVE/WM_NCMOUSEDOWN being sent to the RWHA window which are ignored. Attempted fix is to check in WM_NCHITTEST if the mouse coordinates are in the bottom portion of the window using metrics like SM_CXVSCROLL/SM_CYVSCROLL/SM_CXSIZEFRAME/SM_CYSIZEFRAME and if yes convert the hittest code to HTCLIENT. BUG=335487 R=sky@chromium.org, sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247584

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -10 lines) Patch
M ui/views/win/hwnd_message_handler.cc View 1 chunk +43 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ananta
6 years, 10 months ago (2014-01-28 22:51:24 UTC) #1
sky
LGTM - I wonder if there are any high dpi issues here (feel free to ...
6 years, 10 months ago (2014-01-28 23:58:19 UTC) #2
ananta
6 years, 10 months ago (2014-01-29 01:56:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r247584 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698