Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1455113002:
Refactor RequestInit::areAnyMembersSet (Closed)
DescriptionRefactor RequestInit::areAnyMembersSet
This CL addresses the comments reported in:
https://codereview.chromium.org/1391583002/
https://codereview.chromium.org/1391583002/#msg62
BUG=537138
Committed: https://crrev.com/5a86d3512ece8478f632f614a35b99d0f9130454
Cr-Commit-Position: refs/heads/master@{#360577}
Patch Set 1 #
Messages
Total messages: 20 (8 generated)
Description was changed from ========== clean up comments from "navigate" mode feature BUG=537138 ========== to ========== clean up comments from "navigate" mode feature These CL address comments reported in: https://codereview.chromium.org/1391583002/ https://codereview.chromium.org/1391583002/#msg62 BUG=537138 ==========
shiva.jm@samsung.com changed reviewers: + hiroshige@chromium.org, yhirano@chromium.org
pls have a look.
The CL title/description doesn't directly describe the change (this CL is no longer related to navigate mode, while navigate mode change provides the context for this CL). I'd suggest: Refactor RequestInit::areAnyMembersSet This CL addresses the comments reported in: https://codereview.chromium.org/1391583002/ https://codereview.chromium.org/1391583002/#msg62 BUG=537138
Description was changed from ========== clean up comments from "navigate" mode feature These CL address comments reported in: https://codereview.chromium.org/1391583002/ https://codereview.chromium.org/1391583002/#msg62 BUG=537138 ========== to ========== Refactor RequestInit::areAnyMembersSet This CL addresses the comments reported in: https://codereview.chromium.org/1391583002/ https://codereview.chromium.org/1391583002/#msg62 BUG=537138 ==========
updated the issue description, pls have a look.
lgtm.
The CQ bit was checked by shiva.jm@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455113002/1
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)
The CQ bit was checked by shiva.jm@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455113002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by shiva.jm@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455113002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/5a86d3512ece8478f632f614a35b99d0f9130454 Cr-Commit-Position: refs/heads/master@{#360577} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
