Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1335)

Unified Diff: test/cctest/compiler/test-simplified-lowering.cc

Issue 1455103002: [turbofan] Only infer signedness for Float64->Word32 representation change from the input type. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/compiler/test-representation-change.cc ('k') | test/mjsunit/compiler/regress-f64-w32-change.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/compiler/test-simplified-lowering.cc
diff --git a/test/cctest/compiler/test-simplified-lowering.cc b/test/cctest/compiler/test-simplified-lowering.cc
index 7a06c263ba836ef5c3f9af9f2f1fe2db9ae74e02..1700e330f8e36a9366118f935ae79d31b536da20 100644
--- a/test/cctest/compiler/test-simplified-lowering.cc
+++ b/test/cctest/compiler/test-simplified-lowering.cc
@@ -1203,10 +1203,11 @@ TEST(LowerStringOps_to_call_and_compare) {
}
-void CheckChangeInsertion(IrOpcode::Value expected, MachineType from,
- MachineType to) {
+ void CheckChangeInsertion(IrOpcode::Value expected, MachineType from,
+ MachineType to, Type* type = Type::Any()) {
TestingGraph t(Type::Any());
Node* in = t.ExampleWithOutput(from);
+ NodeProperties::SetType(in, type);
Node* use = t.Use(in, to);
t.Return(use);
t.Lower();
@@ -1216,13 +1217,16 @@ void CheckChangeInsertion(IrOpcode::Value expected, MachineType from,
TEST(InsertBasicChanges) {
- CheckChangeInsertion(IrOpcode::kChangeFloat64ToInt32, kRepFloat64,
- kTypeInt32);
+ CheckChangeInsertion(IrOpcode::kChangeFloat64ToInt32, kRepFloat64, kTypeInt32,
+ Type::Signed32());
CheckChangeInsertion(IrOpcode::kChangeFloat64ToUint32, kRepFloat64,
- kTypeUint32);
- CheckChangeInsertion(IrOpcode::kChangeTaggedToInt32, kRepTagged, kTypeInt32);
- CheckChangeInsertion(IrOpcode::kChangeTaggedToUint32, kRepTagged,
- kTypeUint32);
+ kTypeUint32, Type::Unsigned32());
+ CheckChangeInsertion(IrOpcode::kTruncateFloat64ToInt32, kRepFloat64,
+ kTypeUint32, Type::Integral32());
+ CheckChangeInsertion(IrOpcode::kChangeTaggedToInt32, kRepTagged, kTypeInt32,
+ Type::Signed32());
+ CheckChangeInsertion(IrOpcode::kChangeTaggedToUint32, kRepTagged, kTypeUint32,
+ Type::Unsigned32());
CheckChangeInsertion(IrOpcode::kChangeFloat64ToTagged, kRepFloat64,
kRepTagged);
« no previous file with comments | « test/cctest/compiler/test-representation-change.cc ('k') | test/mjsunit/compiler/regress-f64-w32-change.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698