Fix JS whoopsies from https://crrev.com/e2f61d09c3f

Fix JS whoopsies from https://crrev.com/e2f61d09c3f

BUG=370966, 558025
Committed: https://crrev.com/82bce0e544cd717b38d02284af8d9d7d1d686552
Cr-Commit-Position: refs/heads/master@{#360599}

[robertshield, 2015-11-18 03:52:55]

robertshield@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2015-11-18 17:38:22]

lgtm

https://codereview.chromium.org/1455063003/diff/1/chrome/browser/resources/op...
File chrome/browser/resources/options/automatic_settings_reset_banner.js
(right):

https://codereview.chromium.org/1455063003/diff/1/chrome/browser/resources/op...
chrome/browser/resources/options/automatic_settings_reset_banner.js:50: *
@private {HTMLElement}
nit: ?HTMLElement

https://codereview.chromium.org/1455063003/diff/1/chrome/browser/resources/op...
chrome/browser/resources/options/automatic_settings_reset_banner.js:69:
this.visibleElement_ = $('automatic-settings-reset-banner');
nit:

this.visibleElement_ = getRequiredElement('automatic-settings-reset-banner');

https://codereview.chromium.org/1455063003/diff/1/chrome/browser/resources/op...
chrome/browser/resources/options/automatic_settings_reset_banner.js:116:
chrome.send(this.dismissNativeCallbackName_);
nit: chrome.send(assert(this.dismissNativeCallbackName_));

[robertshield, 2015-11-19 00:04:20]

The CQ bit was checked by robertshield@chromium.org

[robertshield, 2015-11-19 00:04:20]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/1455063003/#ps20001
(title: "Dan's feedback.")

[robertshield, 2015-11-19 00:04:45]

Thanks!

https://codereview.chromium.org/1455063003/diff/1/chrome/browser/resources/op...
File chrome/browser/resources/options/automatic_settings_reset_banner.js
(right):

https://codereview.chromium.org/1455063003/diff/1/chrome/browser/resources/op...
chrome/browser/resources/options/automatic_settings_reset_banner.js:50: *
@private {HTMLElement}
On 2015/11/18 17:38:22, Dan Beam wrote:
> nit: ?HTMLElement

Done.

https://codereview.chromium.org/1455063003/diff/1/chrome/browser/resources/op...
chrome/browser/resources/options/automatic_settings_reset_banner.js:69:
this.visibleElement_ = $('automatic-settings-reset-banner');
On 2015/11/18 17:38:22, Dan Beam wrote:
> nit:
> 
> this.visibleElement_ = getRequiredElement('automatic-settings-reset-banner');

Done.

https://codereview.chromium.org/1455063003/diff/1/chrome/browser/resources/op...
chrome/browser/resources/options/automatic_settings_reset_banner.js:116:
chrome.send(this.dismissNativeCallbackName_);
On 2015/11/18 17:38:22, Dan Beam wrote:
> nit: chrome.send(assert(this.dismissNativeCallbackName_));

Done.

[robertshield, 2015-11-19 00:05:36]

The CQ bit was unchecked by robertshield@chromium.org

[robertshield, 2015-11-19 00:05:51]

Description was changed from

==========
Fix JS whoopsies from https://crrev.com/e2f61d09c3f

BUG=370966
==========

to

==========
Fix JS whoopsies from https://crrev.com/e2f61d09c3f

BUG=370966,558025
==========

[robertshield, 2015-11-19 16:22:02]

The CQ bit was checked by robertshield@chromium.org

[commit-bot: I haz the power, 2015-11-19 16:22:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1455063003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1455063003/20001

[commit-bot: I haz the power, 2015-11-19 16:28:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-19 16:29:30]

Patchset 2 (id:??) landed as
https://crrev.com/82bce0e544cd717b38d02284af8d9d7d1d686552
Cr-Commit-Position: refs/heads/master@{#360599}