Issue 1455053003: Custom property CSSOM patch with templates [not for landing]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1455053003: Custom property CSSOM patch with templates [not for landing] (Closed)

Created:
5 years, 1 month ago by alancutter (OOO until 2018)

Modified:
5 years, 1 month ago

Reviewers:

CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/src.git@_levisPatch

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Custom property CSSOM patch with templates [not for landing] This is an experimental rewrite of https://codereview.chromium.org/1405293012 using templates in StylePropertySet instead of code duplication to see if it's any nicer.

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+116 lines, -121 lines)			Patch
M	third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp	View	3 chunks	+17 lines, -8 lines	0 comments	Download
M	third_party/WebKit/Source/core/css/StylePropertySet.h	View	7 chunks	+29 lines, -26 lines	0 comments	Download
M	third_party/WebKit/Source/core/css/StylePropertySet.cpp	View	7 chunks	+69 lines, -86 lines	0 comments	Download

Depends on Patchset:

Issue 1405293012 Patch 60001