Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 145503008: Clean up MediaControlElement virtual and unused functions (Closed)

Created:
6 years, 10 months ago by philipj_slow
Modified:
6 years, 10 months ago
CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Visibility:
Public.

Description

Clean up MediaControlElement virtual and unused functions This class was a bit confusing: isShowing() was never used. The state of MediaControlElement::shadowPseudoId() was odd. The same virtual function exists on Element, and the MediaControl*Element classes inherit both Element and MediaControlElement. When they override shadowPseudoId() they override both of their base classes. However, MediaControlElement::shadowPseudoId() wasn't ever used... The remaining functions don't need to be virtual since they're never overridden. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166767

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -15 lines) Patch
M Source/core/html/shadow/MediaControlElementTypes.h View 1 chunk +5 lines, -7 lines 0 comments Download
M Source/core/html/shadow/MediaControlElementTypes.cpp View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
6 years, 10 months ago (2014-02-07 18:29:25 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
6 years, 10 months ago (2014-02-07 23:06:13 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 10 months ago (2014-02-08 08:44:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/145503008/1
6 years, 10 months ago (2014-02-08 08:44:29 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-08 09:40:50 UTC) #5
Message was sent while issue was closed.
Change committed as 166767

Powered by Google App Engine
This is Rietveld 408576698