Issue 145503008: Clean up MediaControlElement virtual and unused functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 145503008: Clean up MediaControlElement virtual and unused functions (Closed)

Created:
6 years, 10 months ago by philipj_slow

Modified:
6 years, 10 months ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Clean up MediaControlElement virtual and unused functions This class was a bit confusing: isShowing() was never used. The state of MediaControlElement::shadowPseudoId() was odd. The same virtual function exists on Element, and the MediaControl*Element classes inherit both Element and MediaControlElement. When they override shadowPseudoId() they override both of their base classes. However, MediaControlElement::shadowPseudoId() wasn't ever used... The remaining functions don't need to be virtual since they're never overridden. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166767

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -15 lines)			Patch
	M	Source/core/html/shadow/MediaControlElementTypes.h	View		1 chunk	+5 lines, -7 lines	0 comments	Download
	M	Source/core/html/shadow/MediaControlElementTypes.cpp	View		1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/145503008/1

6 years, 10 months ago (2014-02-08 08:44:29 UTC) #4

Message was sent while issue was closed.

Change committed as 166767

Expand Messages | Collapse Messages