Making GraphicsContext the owner of PlatformContext.

Source/core/platform/graphics/GraphicsContext.cpp

 /*
  * Copyright (C) 2003, 2004, 2005, 2006, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 37 matching lines @@
 #include <wtf/MathExtras.h>
 
 #if OS(DARWIN)
 #include <ApplicationServices/ApplicationServices.h>
 #endif
 
 using namespace std;
 
 namespace WebCore {
 
-GraphicsContext::GraphicsContext(PlatformGraphicsContext* platformGraphicsContext)
+GraphicsContext::GraphicsContext(SkCanvas* canvas)
     : m_updatingControlTints(false)
     , m_transparencyCount(0)
 {
-    if (platformGraphicsContext)
-        platformGraphicsContext->setGraphicsContext(this);
+    m_data = new PlatformContextSkia(canvas);
+    m_data->setGraphicsContext(this);
 
     // the caller owns the gc
-    m_data = platformGraphicsContext;
-    setPaintingDisabled(!platformGraphicsContext || !platformGraphicsContext->canvas());
+    setPaintingDisabled(!canvas);
 }
 
 GraphicsContext::~GraphicsContext()
 {
     ASSERT(m_stack.isEmpty());
     ASSERT(!m_transparencyCount);
+    delete m_data;

[jamesr, 2013/04/29 23:56:17]

can you instead make m_data an OwnPtr<> since you're changing the type anyway?
or just make the storage inline if there's not a specific reason it should be
heap-allocated?

 }
 
 PlatformGraphicsContext* GraphicsContext::platformContext() const
 {
     ASSERT(!paintingDisabled());
     return m_data;
 }
 
 bool GraphicsContext::isAcceleratedContext() const
 {
@@ skipping 1674 matching lines @@
     static const SkPMColor colors[] = {
         SkPreMultiplyARGB(0x60, 0xFF, 0x00, 0x00), // More transparent red
         SkPreMultiplyARGB(0x60, 0xC0, 0xC0, 0xC0)  // More transparent gray
     };
 
     return colors[index];
 }
 #endif
 
 }