QUIC - Code to verify SCT tag with certificate transparency verifier

net/quic/quic_chromium_client_session.cc

Index: net/quic/quic_chromium_client_session.cc
diff --git a/net/quic/quic_chromium_client_session.cc b/net/quic/quic_chromium_client_session.cc
index 41da42047add7588b84242a776871c6df3fac01d..c8809b62aebf9ddb329028f0641146920d42282b 100644
--- a/net/quic/quic_chromium_client_session.cc
+++ b/net/quic/quic_chromium_client_session.cc
@@ -500,6 +500,9 @@ bool QuicChromiumClientSession::GetSSLInfo(SSLInfo* ssl_info) const {
   ssl_info->security_bits = security_bits;
   ssl_info->handshake_type = SSLInfo::HANDSHAKE_FULL;
   ssl_info->pinning_failure_log = pinning_failure_log_;
+
+  ssl_info->UpdateSignedCertificateTimestamps(*ct_verify_result_);
+
   return true;
 }
 
@@ -800,6 +803,9 @@ void QuicChromiumClientSession::OnProofVerifyDetailsAvailable(
   result_copy->CopyFrom(verify_details_chromium->cert_verify_result);
   cert_verify_result_.reset(result_copy);
   pinning_failure_log_ = verify_details_chromium->pinning_failure_log;
+  ct::CTVerifyResult* ct_verify_result_copy = new ct::CTVerifyResult;

[Eran Messeri, 2015/11/23 17:35:19]

Nit: In the past the use of scoped_ptr was recommended to me, any reason not to:
scoped_ptr<ct::CTVerifyResult> ct_verify_result_copy(new ct::CTVerifyResult);
*ct_verify_result_copy = verify_details_chromium->ct_verify_result;
ct_verify_result_ = ct_verify_result_copy.Pass();

?

(even better if the CTVerifyResult had a copy c'tor).

[ramant (doing other things), 2015/11/23 17:57:41]

Acknowledged.

Will modify CTVerifyResult and CertVerifyResult to use scoped_ptr and then call
Pass(). (I am guessing the previous reviewer preferred the current style of
coding. Will switch to using scoped_ptr here and the unittests).

+  *ct_verify_result_copy = verify_details_chromium->ct_verify_result;
+  ct_verify_result_.reset(ct_verify_result_copy);
   logger_->OnCertificateVerified(*cert_verify_result_);
 }