Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 1454983003: Remove unused color from NativeTheme. (Closed)

Created:
5 years, 1 month ago by Evan Stade
Modified:
5 years, 1 month ago
CC:
chromium-reviews, tfarina, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused color from NativeTheme. The "Divider" colors are intended for use for the hyphens that separate e.g. the URL and page title. These hyphens actually just match the DIMMED_TEXT color; I can't find a time in the past where this color was ever used for anything. BUG=501377 Committed: https://crrev.com/c9e3b72e0602b9a920d5d6aa90dc6a29b6eae5cd Cr-Commit-Position: refs/heads/master@{#360436}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -57 lines) Patch
M chrome/browser/ui/libgtk2ui/native_theme_gtk2.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_result_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_result_view.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/native_theme/native_theme.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/native_theme/native_theme_aura.cc View 4 chunks +0 lines, -22 lines 0 comments Download
M ui/native_theme/native_theme_dark_aura.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M ui/native_theme/native_theme_win.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Evan Stade
+a lot of relevant people in hopes that, if this is flawed, at least one ...
5 years, 1 month ago (2015-11-18 01:30:07 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1454983003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1454983003/1
5 years, 1 month ago (2015-11-18 01:30:23 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/58715) chromeos_daisy_chromium_compile_only_ng on ...
5 years, 1 month ago (2015-11-18 01:46:06 UTC) #6
Peter Kasting
LGTM
5 years, 1 month ago (2015-11-18 01:46:12 UTC) #7
Elliot Glaysher
lgtm
5 years, 1 month ago (2015-11-18 18:09:18 UTC) #8
msw
ditto lgtm in case you're waiting for me
5 years, 1 month ago (2015-11-18 19:46:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1454983003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1454983003/20001
5 years, 1 month ago (2015-11-18 22:04:06 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-18 23:06:59 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 23:07:39 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c9e3b72e0602b9a920d5d6aa90dc6a29b6eae5cd
Cr-Commit-Position: refs/heads/master@{#360436}

Powered by Google App Engine
This is Rietveld 408576698