Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: content/child/service_worker/service_worker_dispatcher.h

Issue 1454963003: ServiceWorker: Ensure that ServiceWorkerDispatcher always adopts passed handle references (1) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/child/service_worker/service_worker_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/service_worker/service_worker_dispatcher.h
diff --git a/content/child/service_worker/service_worker_dispatcher.h b/content/child/service_worker/service_worker_dispatcher.h
index 5bd0274a0c21da63c6232cae6b6d7bd1e87143a1..e8c59fcbf9a1c91ee1a67e3392091fefbbd88779 100644
--- a/content/child/service_worker/service_worker_dispatcher.h
+++ b/content/child/service_worker/service_worker_dispatcher.h
@@ -23,10 +23,6 @@ namespace base {
class SingleThreadTaskRunner;
}
-namespace blink {
-class WebURL;
-}
-
namespace IPC {
class Message;
}
@@ -35,6 +31,7 @@ struct ServiceWorkerMsg_MessageToDocument_Params;
namespace content {
+class ServiceWorkerHandleReference;
class ServiceWorkerMessageFilter;
class ServiceWorkerProviderContext;
class ServiceWorkerRegistrationHandleReference;
@@ -264,6 +261,13 @@ class CONTENT_EXPORT ServiceWorkerDispatcher : public WorkerThread::Observer {
void RemoveServiceWorkerRegistration(
int registration_handle_id);
+ // Assumes that the given object information retains an interprocess handle
+ // reference passed from the browser process, and adopts it.
+ scoped_ptr<ServiceWorkerRegistrationHandleReference> Adopt(
+ const ServiceWorkerRegistrationObjectInfo& info);
+ scoped_ptr<ServiceWorkerHandleReference> Adopt(
+ const ServiceWorkerObjectInfo& info);
+
RegistrationCallbackMap pending_registration_callbacks_;
UpdateCallbackMap pending_update_callbacks_;
UnregistrationCallbackMap pending_unregistration_callbacks_;
« no previous file with comments | « no previous file | content/child/service_worker/service_worker_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698