win: Remove msbuild_toolset, and msvs-specific ProgramDatabaseFile.

win: Remove msbuild_toolset, and msvs-specific ProgramDatabaseFile.

Since we're now on ninja, they don't have an effect.

BUG=none
R=scottmg@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246783

[scottmg, 2014-01-24 00:43:42]

Lgtm
On Jan 23, 2014 4:37 PM, <thakis@chromium.org> wrote:

> Reviewers: scottmg,
>
> Description:
> win: Remove msbuild_toolset, and msvs-specific ProgramDatabaseFile.
>
> Since we're now on ninja, they don't have an effect.
>
> BUG=none
>
> Please review this at https://codereview.chromium.org/145493007/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+0, -16 lines):
>   M build/common.gypi
>
>
> Index: build/common.gypi
> diff --git a/build/common.gypi b/build/common.gypi
> index ae53af23405f48d9fb81ce390134e778aa6598f7..
> 7d83fdee5d01a99f6d61c6a3e72a5aa2b221f40a 100644
> --- a/build/common.gypi
> +++ b/build/common.gypi
> @@ -1199,9 +1199,6 @@
>      # Disable Dart by default.
>      'enable_dart%': 0,
>
> -    # The desired version of Windows SDK can be set in
> ~/.gyp/include.gypi.
> -    'msbuild_toolset%': '',
> -
>      # Native Client is enabled by default.
>      'disable_nacl%': 0,
>
> @@ -2087,9 +2084,6 @@
>          # See http://crbug.com/162818.
>          'cflags+': ['-Wno-sentinel'],
>        }],
> -      ['OS=="win" and "<(msbuild_toolset)"!=""', {
> -        'msbuild_toolset': '<(msbuild_toolset)',
> -      }],
>        ['branding=="Chrome"', {
>          'defines': ['GOOGLE_CHROME_BUILD'],
>        }, {  # else: branding!="Chrome"
> @@ -2359,16 +2353,6 @@
>                }
>              }
>            }],
> -          ['"<(GENERATOR)"=="msvs"', {
> -            'msvs_settings': {
> -              'VCLinkerTool': {
> -                # Make the pdb name sane. Otherwise foo.exe and foo.dll
> both
> -                # have foo.pdb. The ninja generator already defaults to
> this and
> -                # can't handle the $(TargetPath) macro.
> -                'ProgramDatabaseFile': '$(TargetPath).pdb',
> -              }
> -            },
> -          }],
>          ],  # win_z7!=0
>        }],  # OS==win
>        ['enable_task_manager==1', {
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-01-24 00:49:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/145493007/1

[Nico, 2014-01-24 04:36:27]

Committed patchset #1 manually as r246783 (tree was closed).