Source/core/page/HistoryController.h - Issue 145493005: Keep frames to navigate alive in HistoryController::goToEntry()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/HistoryController.h

Issue 145493005: Keep frames to navigate alive in HistoryController::goToEntry() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/HistoryController.h

diff --git a/Source/core/page/HistoryController.h b/Source/core/page/HistoryController.h

index fc8188381d59dad8363d81c6d485f8cdcb417b6c..f93dce185f1b8c599611385ea5ed91480780abe8 100644

--- a/Source/core/page/HistoryController.h

+++ b/Source/core/page/HistoryController.h

@@ -155,7 +155,8 @@ public:

private:

void goToEntry(PassOwnPtr<HistoryEntry>, ResourceRequestCachePolicy);

- typedef HashMap<Frame*, HistoryItem*> HistoryFrameLoadSet;

+ class HistoryFrameLoad;

+ typedef HashMap<Frame*, OwnPtr<HistoryFrameLoad> > HistoryFrameLoadSet;

Nate Chapin 2014/01/23 18:19:11 Can we change this to Hashmap<RefPtr<Frame>, Histo

Jens Widell 2014/01/23 18:52:18 Certainly; much better that way. I think I assume

void recursiveGoToEntry(Frame*, HistoryFrameLoadSet& sameDocumentLoads, HistoryFrameLoadSet& differentDocumentLoads);

void updateForInitialLoadInChildFrame(Frame*, HistoryItem*);

« no previous file with comments | « Source/core/loader/FrameLoader.cpp ('k') | Source/core/page/HistoryController.cpp » ('j') | Source/core/page/HistoryController.cpp » ('J')