LayoutTests/fast/loader/remove-iframe-during-history-navigation-same.html - Issue 145493005: Keep frames to navigate alive in HistoryController::goToEntry()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/loader/remove-iframe-during-history-navigation-same.html

Issue 145493005: Keep frames to navigate alive in HistoryController::goToEntry() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: improved as suggested in review Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/loader/remove-iframe-during-history-navigation-different-expected.txt ('k') | LayoutTests/fast/loader/remove-iframe-during-history-navigation-same-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!-- One iframe's popstate handler removes another iframe from the

	2 document during a history navigation that affects both frames. The

	3 history navigation selects the same document in both frames.

	4

	5 Should not crash. -->

	6

	7 <script>

	8 if (window.testRunner) {

	9 testRunner.dumpAsText();

	10 testRunner.waitUntilDone();

	11 }

	12

	13 window.onload = function () {

	14 frames[0].history.pushState("first", "first");

	15 frames[0].onpopstate = function () {

	16 document.body.innerHTML = "PASS";

	17 if (window.testRunner)

	18 testRunner.notifyDone();

	19 };

	20 frames[1].history.pushState("second", "second");

	21

	22 history.go(-2);

	23 }

	24 </script>

	25

	26 <body>

	27 NOT TESTED

	28 <iframe src="resources/empty-subframe.html"></iframe>

	29 <iframe src="resources/empty-subframe.html"></iframe>

	30 </body>

OLD	NEW