Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Unified Diff: content/browser/webui/web_ui_impl.h

Issue 1454883006: Revert of Reland #1 of: Move WebUI ownership from the RenderFrameHostManager to the RenderFrameHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/webui/web_ui_impl.h
diff --git a/content/browser/webui/web_ui_impl.h b/content/browser/webui/web_ui_impl.h
index a59b4a533da6d4f15902f42d223446ab118bfa86..86c70711282a2ec7c9e7aa78d9954b27387c7f57 100644
--- a/content/browser/webui/web_ui_impl.h
+++ b/content/browser/webui/web_ui_impl.h
@@ -25,13 +25,13 @@
WebUIImpl(WebContents* contents, const std::string& frame_name);
~WebUIImpl() override;
- // Called when a RenderView is created for a WebUI (reload after a renderer
- // crash) or when a WebUI is created for an RenderView (i.e. navigating from
- // chrome://downloads to chrome://bookmarks) or when both are new (i.e.
- // opening a new tab).
+ // Called by WebContentsImpl when the RenderView is first created. This is
+ // *not* called for every page load because in some cases
+ // RenderFrameHostManager will reuse RenderView instances.
void RenderViewCreated(RenderViewHost* render_view_host);
- // Called when a RenderView is reused for the same WebUI type (i.e. reload).
+ // Called by WebContentsImpl when the RenderView is reused. This happens on
+ // refresh or when the main page is navigated within the same SiteInstance.
void RenderViewReused(RenderViewHost* render_view_host, bool was_main_frame);
// WebUI implementation:
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698