Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1454883006: Revert of Reland #1 of: Move WebUI ownership from the RenderFrameHostManager to the RenderFrameHost. (Closed)

Created:
5 years, 1 month ago by grt (UTC plus 2)
Modified:
5 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland #1 of: Move WebUI ownership from the RenderFrameHostManager to the RenderFrameHost. (patchset #12 id:260001 of https://codereview.chromium.org/1426403006/ ) Reason for revert: ExtensionApiTest.Debugger browser_tests failed on Win7 Tests (dbg)(1) Build #43339 with [3192:3164:1120/071447:FATAL:render_frame_host_manager.cc(2372)] Check failed: !render_frame_host_->pending_web_ui(). Which was introduced with this change. Original issue's description: > Reland #1 of: Move WebUI ownership from the RenderFrameHostManager to the RenderFrameHost. > (Revert: https://codereview.chromium.org/1422043007/) > > This change refactors the current ownership of the WebUI instance, > moving it from the RenderFrameHostManager to the RenderFrameHost which > is directly associated with the WebUI. > > The design document for this change is here: > https://docs.google.com/a/chromium.org/document/d/1jrge5ulZ1YtqSR3WkNXzrtxhd3JXcWm8_zWBhEjaJtI > > BUG=508850, 552253 > > Committed: https://crrev.com/113503ad7f6957c1eb2bb12215c8d5fae3303ef6 > Cr-Commit-Position: refs/heads/master@{#360807} TBR=clamy@chromium.org,nasko@chromium.org,creis@chromium.org,dbeam@chromium.org,carlosk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=508850, 552253 Committed: https://crrev.com/4b8f0132c24e2ba0890192c9e5117f1c05cdf54d Cr-Commit-Position: refs/heads/master@{#360828}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+353 lines, -675 lines) Patch
M content/browser/frame_host/frame_tree.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/frame_host/render_frame_host_delegate.h View 2 chunks +0 lines, -5 lines 0 comments Download
M content/browser/frame_host/render_frame_host_delegate.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 4 chunks +0 lines, -45 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 6 chunks +0 lines, -101 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.h View 14 chunks +88 lines, -36 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 29 chunks +201 lines, -143 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_browsertest.cc View 1 chunk +7 lines, -10 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_unittest.cc View 11 chunks +25 lines, -303 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 6 chunks +19 lines, -15 lines 0 comments Download
M content/browser/webui/web_ui_impl.h View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
grt (UTC plus 2)
Created Revert of Reland #1 of: Move WebUI ownership from the RenderFrameHostManager to the RenderFrameHost.
5 years, 1 month ago (2015-11-20 16:01:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1454883006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1454883006/1
5 years, 1 month ago (2015-11-20 16:03:00 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-20 16:04:16 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 16:05:26 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b8f0132c24e2ba0890192c9e5117f1c05cdf54d
Cr-Commit-Position: refs/heads/master@{#360828}

Powered by Google App Engine
This is Rietveld 408576698