Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 1454773002: Play better with C++11 library features from /chromeos (Closed)

Created:
5 years, 1 month ago by limasdf
Modified:
5 years ago
CC:
chromium-reviews, oshima+watch_chromium.org, hashimoto+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Play better with C++11 library features from /chromeos - Get rid of ScopedPtrMap - Get rid of linked_ptr - Replace Pass() with std::move() BUG=554291, 557422, 556939 TBR=cschuet@chromium.org Committed: https://crrev.com/ba1b9cf98c3653adf2773d3df38465a8ee1d2016 Cr-Commit-Position: refs/heads/master@{#361509}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -25 lines) Patch
M chromeos/dbus/gsm_sms_client.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chromeos/dbus/modem_messaging_client.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chromeos/dbus/shill_ipconfig_client.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M chromeos/dbus/shill_profile_client.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M chromeos/network/managed_network_configuration_handler_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chromeos/network/managed_network_configuration_handler_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 28 (15 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1454773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1454773002/1
5 years, 1 month ago (2015-11-17 23:57:44 UTC) #2
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 1 month ago (2015-11-17 23:57:45 UTC) #4
limasdf
PTAL when you have time.
5 years, 1 month ago (2015-11-18 03:53:38 UTC) #10
limasdf
Mind taking a look?
5 years ago (2015-11-22 11:42:34 UTC) #11
limasdf
oshima@ Would you miind taking a look?
5 years ago (2015-11-24 11:40:23 UTC) #13
oshima
lgtm
5 years ago (2015-11-24 22:22:11 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1454773002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1454773002/60001
5 years ago (2015-11-24 22:23:12 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/121983)
5 years ago (2015-11-24 23:47:16 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1454773002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1454773002/60001
5 years ago (2015-11-24 23:54:11 UTC) #20
limasdf
TBRing chromeos/network/
5 years ago (2015-11-24 23:58:53 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1454773002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1454773002/60001
5 years ago (2015-11-25 00:09:38 UTC) #26
commit-bot: I haz the power
Committed patchset #1 (id:60001)
5 years ago (2015-11-25 01:10:46 UTC) #27
commit-bot: I haz the power
5 years ago (2015-11-25 01:12:00 UTC) #28
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba1b9cf98c3653adf2773d3df38465a8ee1d2016
Cr-Commit-Position: refs/heads/master@{#361509}

Powered by Google App Engine
This is Rietveld 408576698