Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 1454753002: Resize extension action icons to 16x16 in material design (Closed)

Created:
5 years, 1 month ago by tdanderson
Modified:
5 years, 1 month ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Resize extension action icons to 16x16 in material design Shrink the 19x19 extension action icons to 16x16 in top chrome material design so they match the size and alignment of the other icons in the toolbar. BUG=546206 TEST=manual Committed: https://crrev.com/60a14060edc30c719915991b6c02dfd33f335676 Cr-Commit-Position: refs/heads/master@{#360103}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M chrome/browser/ui/extensions/extension_action_view_controller.cc View 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
tdanderson
Hi Devlin, can you please take a look?
5 years, 1 month ago (2015-11-17 15:37:13 UTC) #2
Devlin
lgtm as a temporary solution for MD.
5 years, 1 month ago (2015-11-17 17:28:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1454753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1454753002/1
5 years, 1 month ago (2015-11-17 17:41:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-17 17:46:18 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 17:47:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60a14060edc30c719915991b6c02dfd33f335676
Cr-Commit-Position: refs/heads/master@{#360103}

Powered by Google App Engine
This is Rietveld 408576698