Chromium for Mac cannot print surrogate pair in vertical writing mode

Chromium for Mac cannot print surrogate pair in vertical writing mode

CoreText doesn't have vertical glyphs of surrogate pair characters, and
we draw broken glyphs. On Safari, wkGetVerticalGlyphsForCharacters
returns true, and we use the glyphs which is returned from the
SPI. However, according to the description of r149659,
WKGetVerticalGlyphsForCharacters() just returns false on
Chromium. Therefore, we cannot get vertical glyphs from Mac API/SPI.

To work around that, we should not use CoreText for surrogate pair
characters in vertical writing mode, but this always returns horizontal
glyphs.

BUG=337080
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166358

[yuki.sekiguchi, 2014-01-24 02:36:57]

Hi Levi,

Could you review my patch?

[leviw_travelin_and_unemployed, 2014-01-28 19:16:39]

Adding eae@ who may have comments.

https://codereview.chromium.org/145473002/diff/90001/Source/platform/fonts/ma...
File Source/platform/fonts/mac/GlyphPageTreeNodeMac.cpp (right):

https://codereview.chromium.org/145473002/diff/90001/Source/platform/fonts/ma...
Source/platform/fonts/mac/GlyphPageTreeNodeMac.cpp:49: // CoreText doesn't have
vertical glyphs of surrogate pair characters, and we draw broken glyphs.
If I understand this patch, your change is to make us no longer draw broken
glyphs, so this comment seems wrong.

https://codereview.chromium.org/145473002/diff/90001/Source/platform/fonts/ma...
Source/platform/fonts/mac/GlyphPageTreeNodeMac.cpp:51: // FIXME: We should use
vertical glyphs.
Please add a reference to a bug number.

[yuki.sekiguchi, 2014-02-03 06:33:14]

On 2014/01/28 19:16:39, Levi wrote:
> Adding eae@ who may have comments.
> 
>
https://codereview.chromium.org/145473002/diff/90001/Source/platform/fonts/ma...
> File Source/platform/fonts/mac/GlyphPageTreeNodeMac.cpp (right):
> 
>
https://codereview.chromium.org/145473002/diff/90001/Source/platform/fonts/ma...
> Source/platform/fonts/mac/GlyphPageTreeNodeMac.cpp:49: // CoreText doesn't
have
> vertical glyphs of surrogate pair characters, and we draw broken glyphs.
> If I understand this patch, your change is to make us no longer draw broken
> glyphs, so this comment seems wrong.
> 
>
https://codereview.chromium.org/145473002/diff/90001/Source/platform/fonts/ma...
> Source/platform/fonts/mac/GlyphPageTreeNodeMac.cpp:51: // FIXME: We should use
> vertical glyphs.
> Please add a reference to a bug number.

Fixed.

[yuki.sekiguchi, 2014-02-03 06:36:25]

Hi Levi, eae@

Could you review my patch?

[leviw_travelin_and_unemployed, 2014-02-04 00:43:10]

lgtm

[commit-bot: I haz the power, 2014-02-04 00:43:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yuki.sekiguchi@access-company.com/1454...

[commit-bot: I haz the power, 2014-02-04 07:02:32]

Change committed as 166358