Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 1454673002: Debugger: speed up setting break points in nested SFI. (Closed)

Created:
5 years, 1 month ago by Yang
Modified:
5 years, 1 month ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Debugger: speed up setting break points in nested SFI. If the shared function info is newly compiled when looking for it in the script (Debug::FindSharedFunctionInfoInScript), then we can bypass iterating the heap to find JSFunctions referencing it (Debug::PrepareFunctionForBreakpoints). BUG=v8:4553 LOG=N Committed: https://crrev.com/de884f201ad9adf96a3c1ac4f99c23b5dd996e05 Cr-Commit-Position: refs/heads/master@{#32107}

Patch Set 1 #

Patch Set 2 : correction #

Patch Set 3 : fix condition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
M src/debug/debug.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/debug/debug.cc View 1 2 5 chunks +21 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Yang
5 years, 1 month ago (2015-11-18 07:25:10 UTC) #3
Yang
On 2015/11/18 07:25:10, Yang wrote: Ulan, I fixed the condition. A bit different than what ...
5 years, 1 month ago (2015-11-18 14:47:25 UTC) #4
ulan
lgtm
5 years, 1 month ago (2015-11-19 09:04:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1454673002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1454673002/40001
5 years, 1 month ago (2015-11-19 09:47:56 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-19 10:38:33 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 10:39:17 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/de884f201ad9adf96a3c1ac4f99c23b5dd996e05
Cr-Commit-Position: refs/heads/master@{#32107}

Powered by Google App Engine
This is Rietveld 408576698