Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 1454663002: Generate list of GPU contexts outside ImageTest tests (Closed)

Created:
5 years, 1 month ago by Kimmo Kinnunen
Modified:
5 years ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@commandbuffer-as-api-01-gpu-test-context-support
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Generate list of GPU contexts outside ImageTest tests Use DEF_GPUTEST_FOR_*_CONTEXT macros to obtain the test GPU context. Makes changing the context -related classes easier, since not all tests need to be changed. BUG=skia:2992 Committed: https://skia.googlesource.com/skia/+/7b94c1479fc4ab3b7526808ac83c73f48d3cd721

Patch Set 1 #

Patch Set 2 : fix mac build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -256 lines) Patch
M tests/ImageTest.cpp View 1 13 chunks +209 lines, -256 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
Kimmo Kinnunen
5 years, 1 month ago (2015-11-17 10:16:42 UTC) #2
bsalomon
lgtm
5 years, 1 month ago (2015-11-19 15:31:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1454663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1454663002/1
5 years ago (2015-11-24 14:06:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.8-Clang-x86_64-Release-Trybot/builds/6830)
5 years ago (2015-11-24 14:08:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1454663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1454663002/20001
5 years ago (2015-11-24 15:26:46 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-24 15:39:42 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/7b94c1479fc4ab3b7526808ac83c73f48d3cd721

Powered by Google App Engine
This is Rietveld 408576698