Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Unified Diff: chrome/renderer/extensions/request_sender.h

Issue 145463002: Extensions: Send the tab id to platform apps. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix null pointer deref Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/extensions/messaging_bindings.cc ('k') | chrome/renderer/extensions/request_sender.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/request_sender.h
===================================================================
--- chrome/renderer/extensions/request_sender.h (revision 248111)
+++ chrome/renderer/extensions/request_sender.h (working copy)
@@ -42,6 +42,20 @@
const std::string& error) = 0;
};
+ // Helper class to (re)set the |source_tab_id_| below.
+ class ScopedTabID {
+ public:
+ ScopedTabID(RequestSender* request_sender, int tab_id);
+ ~ScopedTabID();
+
+ private:
+ RequestSender* const request_sender_;
+ const int tab_id_;
+ const int previous_tab_id_;
+
+ DISALLOW_COPY_AND_ASSIGN(ScopedTabID);
+ };
+
explicit RequestSender(Dispatcher* dispatcher);
~RequestSender();
@@ -73,6 +87,7 @@
void InvalidateSource(Source* source);
private:
+ friend class ScopedTabID;
typedef std::map<int, linked_ptr<PendingRequest> > PendingRequestMap;
void InsertRequest(int request_id, PendingRequest* pending_request);
@@ -81,6 +96,8 @@
Dispatcher* dispatcher_;
PendingRequestMap pending_requests_;
+ int source_tab_id_; // Id of the tab sending the request, or -1 if no tab.
+
DISALLOW_COPY_AND_ASSIGN(RequestSender);
};
« no previous file with comments | « chrome/renderer/extensions/messaging_bindings.cc ('k') | chrome/renderer/extensions/request_sender.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698