third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.h - Issue 1454623002: Hit test SVG line boxes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.h

Issue 1454623002: Hit test SVG line boxes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add forgotten test. Sorry, test! Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp ('k') | third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.h

diff --git a/third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.h b/third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.h

index 525a1cf0e696ace5768cc33c93c08473e1145cfe..cf5d704cf8b5b2b008df3be8632fda629aa79533 100644

--- a/third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.h

+++ b/third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.h

@@ -49,6 +49,8 @@ public:

InlineBox* closestLeafChildForPosition(const LayoutPoint&);

+ bool nodeAtPoint(HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, LayoutUnit lineTop, LayoutUnit lineBottom) final;

private:

void reorderValueLists(Vector<SVGTextLayoutAttributes*>&);

void layoutChildBoxes(InlineFlowBox*, LayoutRect* = nullptr);