third_party/WebKit/Source/core/layout/line/RootInlineBox.h - Issue 1454623002: Hit test SVG line boxes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/RootInlineBox.h

Issue 1454623002: Hit test SVG line boxes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup extra debugging code and minor bugs Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/svg/hittest/text-with-text-node-and-content-elements.svg ('K') | « third_party/WebKit/LayoutTests/svg/hittest/text-with-text-path-expected.txt ('k') | third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp » ('j') | third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/line/RootInlineBox.h

diff --git a/third_party/WebKit/Source/core/layout/line/RootInlineBox.h b/third_party/WebKit/Source/core/layout/line/RootInlineBox.h

index a06f1d7564da26bf759dbbcdfdce52a596ab3d7f..1f6b1d6bb93d8c76eacbe07f31dac2b7a3127f87 100644

--- a/third_party/WebKit/Source/core/layout/line/RootInlineBox.h

+++ b/third_party/WebKit/Source/core/layout/line/RootInlineBox.h

@@ -107,7 +107,7 @@ public:

LayoutUnit lineHeight() const final;

void paint(const PaintInfo&, const LayoutPoint&, LayoutUnit lineTop, LayoutUnit lineBottom) const override;

- bool nodeAtPoint(HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, LayoutUnit lineTop, LayoutUnit lineBottom) final;

+ bool nodeAtPoint(HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, LayoutUnit lineTop, LayoutUnit lineBottom) override;

using InlineBox::hasSelectedChildren;

using InlineBox::setHasSelectedChildren;