Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1454603002: Update data in chrome://site-engagement periodically. (Closed)

Created:
5 years, 1 month ago by calamity
Modified:
5 years, 1 month ago
Reviewers:
tsergeant
CC:
arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update data in chrome://site-engagement periodically. This CL makes the chrome://site-engagement table update every 2 seconds. BUG=524857 Committed: https://crrev.com/505943a7b8d732995fe6a1e8ac37ec681eb1e929 Cr-Commit-Position: refs/heads/master@{#360301}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M chrome/browser/resources/engagement/site_engagement.js View 1 chunk +12 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
calamity
5 years, 1 month ago (2015-11-18 02:41:37 UTC) #3
tsergeant
lgtm
5 years, 1 month ago (2015-11-18 05:39:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1454603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1454603002/20001
5 years, 1 month ago (2015-11-18 06:04:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 1 month ago (2015-11-18 07:25:49 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 07:26:39 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/505943a7b8d732995fe6a1e8ac37ec681eb1e929
Cr-Commit-Position: refs/heads/master@{#360301}

Powered by Google App Engine
This is Rietveld 408576698