runtime/vm/compiler_test.cc - Issue 1454553004: Create code and instruction object, and install them in the background compilation thread while br…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/compiler_test.cc

Issue 1454553004: Create code and instruction object, and install them in the background compilation thread while br… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/compiler_test.cc

diff --git a/runtime/vm/compiler_test.cc b/runtime/vm/compiler_test.cc

index 03ef98ff45afb5b03a3e616c3f3faccb156b5f14..cab15939c33e2e5112f97713103485095de6d9a7 100644

--- a/runtime/vm/compiler_test.cc

+++ b/runtime/vm/compiler_test.cc

@@ -10,6 +10,7 @@

#include "vm/object.h"

#include "vm/symbols.h"

#include "vm/thread_pool.h"

+#include "vm/thread_registry.h"

#include "vm/unit_test.h"

namespace dart {

@@ -105,7 +106,7 @@ TEST_CASE(CompileFunctionOnHelperThread) {

Monitor* m = new Monitor();

MonitorLocker ml(m);

while (!func.HasOptimizedCode()) {

- isolate->background_compiler()->InstallGeneratedCode();

+ Isolate::Current()->thread_registry()->CheckSafepoint();

ml.Wait(1);

}

BackgroundCompiler::Stop(isolate->background_compiler());

« no previous file with comments | « runtime/vm/compiler.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »