[es6] Allow any valid repeat of empty string in String.prototype.repeat

[es6] Allow any valid repeat of empty string in String.prototype.repeat

This lets us pass one test262 test (and seems to match what other
implementations do to handle this case).

R=littledan@chromium.org
BUG=v8:4362
LOG=n

Committed: https://crrev.com/8e2e69a4b5ee9f39940ef4d15907d7fefa74da8d
Cr-Commit-Position: refs/heads/master@{#32155}

[Dan Ehrenberg, 2015-11-17 01:29:52]

lgtm

Test?

[Dan Ehrenberg, 2015-11-17 01:30:17]

I guess test262 would be enough, but you make two changes here--does test262
cover both of them?

[adamk, 2015-11-20 23:34:16]

Description was changed from

==========
[es6] Allow any valid repeat of empty string in String.prototype.repeat

This lets us pass one test262 test (and seems to match what other
implementations do to handle this case).

R=littledan@chromium.org
BUG=v8:4362
==========

to

==========
[es6] Allow any valid repeat of empty string in String.prototype.repeat

This lets us pass one test262 test (and seems to match what other
implementations do to handle this case).

R=littledan@chromium.org
BUG=v8:4362
LOG=n
==========

[adamk, 2015-11-20 23:34:33]

Added a few tests (particular for the empty string, INFINITY case).

[adamk, 2015-11-20 23:34:36]

The CQ bit was checked by adamk@chromium.org

[adamk, 2015-11-20 23:34:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
littledan@chromium.org
Link to the patchset: https://codereview.chromium.org/1454543003/#ps20001
(title: "Add a few tests for empty strings")

[commit-bot: I haz the power, 2015-11-20 23:34:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1454543003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1454543003/20001

[commit-bot: I haz the power, 2015-11-20 23:35:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-20 23:35:29]

Try jobs failed on following builders:
  v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)
  v8_linux64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/12104)
  v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1...)
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/10411)
  v8_linux_dbg on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/11020)
  v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)
  v8_linux_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/11992)
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/7961)

[adamk, 2015-11-20 23:37:28]

The CQ bit was checked by adamk@chromium.org

[adamk, 2015-11-20 23:37:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
littledan@chromium.org
Link to the patchset: https://codereview.chromium.org/1454543003/#ps40001
(title: "Rebased")

[commit-bot: I haz the power, 2015-11-20 23:37:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1454543003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1454543003/40001

[commit-bot: I haz the power, 2015-11-20 23:57:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-20 23:57:47]

Patchset 3 (id:??) landed as
https://crrev.com/8e2e69a4b5ee9f39940ef4d15907d7fefa74da8d
Cr-Commit-Position: refs/heads/master@{#32155}