test/win/gyptest-link-update-manifest.py - Issue 1454433002: Python 3 compatibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/win/gyptest-link-update-manifest.py

Issue 1454433002: Python 3 compatibility Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: Rebase with master (4ec6c4e3a94bd04a6da2858163d40b2429b8aad1) Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/win/gyptest-link-update-manifest.py

diff --git a/test/win/gyptest-link-update-manifest.py b/test/win/gyptest-link-update-manifest.py

index 4f8b2b91120b83d560035c064db8dc33d6e56b53..693db270279f2b6c157480f463699277067d23aa 100644

--- a/test/win/gyptest-link-update-manifest.py

+++ b/test/win/gyptest-link-update-manifest.py

@@ -75,7 +75,7 @@ if sys.platform == 'win32':

gypfile = 'update-manifest.gyp'

def WriteAndUpdate(uac_execution_level, additional_manifest_files, do_build):

- with open(os.path.join(CHDIR, gypfile), 'wb') as f:

+ with open(os.path.join(CHDIR, gypfile), 'w') as f:

f.write(gyp_template % {

'uac_execution_level': uac_execution_level,

'additional_manifest_files': additional_manifest_files,