test/win/generator-output-different-drive/gyptest-generator-output-different-drive.py - Issue 1454433002: Python 3 compatibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/win/generator-output-different-drive/gyptest-generator-output-different-drive.py

Issue 1454433002: Python 3 compatibility Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: Rebase with master (4ec6c4e3a94bd04a6da2858163d40b2429b8aad1) Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« test/variables/commands/commands.gyp ('K') | « test/variables/filelist/gyptest-filelist-golden.py ('k') | test/win/gyptest-cl-enable-enhanced-instruction-set.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/win/generator-output-different-drive/gyptest-generator-output-different-drive.py

diff --git a/test/win/generator-output-different-drive/gyptest-generator-output-different-drive.py b/test/win/generator-output-different-drive/gyptest-generator-output-different-drive.py

index 8c8c365d5ee81a4de98ca0785068647fa877b37c..96a30ec5b988618aae79c9f14fd77aa7246d175e 100644

--- a/test/win/generator-output-different-drive/gyptest-generator-output-different-drive.py

+++ b/test/win/generator-output-different-drive/gyptest-generator-output-different-drive.py

@@ -22,7 +22,7 @@ if sys.platform == 'win32':

def GetFirstFreeDriveLetter():

""" Returns the first unused Windows drive letter in [A, Z] """

- all_letters = [c for c in string.uppercase]

+ all_letters = [c for c in string.ascii_uppercase]

in_use = win32api.GetLogicalDriveStrings()

free = list(set(all_letters) - set(in_use))

return free[0]