test/symlinks/gyptest-symlinks.py - Issue 1454433002: Python 3 compatibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/symlinks/gyptest-symlinks.py

Issue 1454433002: Python 3 compatibility Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: Rebase with master (4ec6c4e3a94bd04a6da2858163d40b2429b8aad1) Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/symlinks/gyptest-symlinks.py

diff --git a/test/symlinks/gyptest-symlinks.py b/test/symlinks/gyptest-symlinks.py

index f0c2d515641f4975cb1d5227ac35682ea19aa44b..278818a992eeddb666f55bfae302b0bdb4c56bb7 100755

--- a/test/symlinks/gyptest-symlinks.py

+++ b/test/symlinks/gyptest-symlinks.py

@@ -28,8 +28,8 @@ if sys.platform != 'win32':

# symlinked back and processed. Note that we don't ask gyp to touch the

# original files at all; they are only there as source material for the copy.

# That's why hello.gyp references symlink_hello.c instead of hello.c.

- with tempfile.NamedTemporaryFile() as gyp_file:

- with tempfile.NamedTemporaryFile() as c_file:

+ with tempfile.NamedTemporaryFile(mode='w+') as gyp_file:

+ with tempfile.NamedTemporaryFile(mode='w+') as c_file:

with open('hello.gyp') as orig_gyp_file:

gyp_file.write(orig_gyp_file.read())

gyp_file.flush()