test/rules-rebuild/src/make-sources.py - Issue 1454433002: Python 3 compatibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/rules-rebuild/src/make-sources.py

Issue 1454433002: Python 3 compatibility Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: Rebase with master (4ec6c4e3a94bd04a6da2858163d40b2429b8aad1) Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/rules-rebuild/src/make-sources.py

diff --git a/test/rules-rebuild/src/make-sources.py b/test/rules-rebuild/src/make-sources.py

index 7ec022780c04f17c1a761ae2ebe070c0d2953158..dd9e52856e3e5e4ff42bfa32f04cae592560d481 100755

--- a/test/rules-rebuild/src/make-sources.py

+++ b/test/rules-rebuild/src/make-sources.py

@@ -10,9 +10,9 @@ assert len(sys.argv) == 4, sys.argv

(in_file, c_file, h_file) = sys.argv[1:]

def write_file(filename, contents):

- open(filename, 'wb').write(contents)

+ open(filename, 'w').write(contents)

-write_file(c_file, open(in_file, 'rb').read())

+write_file(c_file, open(in_file, 'r').read())

write_file(h_file, '#define NAME "%s"\n' % in_file)