Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/no-cpp/gyptest-no-cpp.py

Issue 1454433002: Python 3 compatibility Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: Rebase with master (4ec6c4e3a94bd04a6da2858163d40b2429b8aad1) Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« test/lib/TestGyp.py ('K') | « test/ninja/solibs_avoid_relinking/gyptest-solibs-avoid-relinking.py ('k') | test/rules-dirname/gyptest-dirname.py » ('j') | test/variables/commands/commands.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/no-cpp/gyptest-no-cpp.py
diff --git a/test/no-cpp/gyptest-no-cpp.py b/test/no-cpp/gyptest-no-cpp.py
index d37e3c194b71a226bc0b315a3843bf295fb8b784..05e5a4324a9c2e8f86f40cab0a9673995367a1bb 100644
--- a/test/no-cpp/gyptest-no-cpp.py
+++ b/test/no-cpp/gyptest-no-cpp.py
@@ -27,9 +27,11 @@ if sys.platform != 'win32' and test.format != 'make':
def LinksLibStdCpp(path):
path = test.built_file_path(path, chdir=CHDIR)
if sys.platform == 'darwin':
- proc = subprocess.Popen(['otool', '-L', path], stdout=subprocess.PIPE)
+ proc = subprocess.Popen(['otool', '-L', path], stdout=subprocess.PIPE,
+ universal_newlines=True)
else:
- proc = subprocess.Popen(['ldd', path], stdout=subprocess.PIPE)
+ proc = subprocess.Popen(['ldd', path], stdout=subprocess.PIPE,
+ universal_newlines=True)
output = proc.communicate()[0]
assert not proc.returncode
return 'libstdc++' in output or 'libc++' in output
« test/lib/TestGyp.py ('K') | « test/ninja/solibs_avoid_relinking/gyptest-solibs-avoid-relinking.py ('k') | test/rules-dirname/gyptest-dirname.py » ('j') | test/variables/commands/commands.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698