test/make_global_settings/ld/gyptest-make_global_settings_ld.py - Issue 1454433002: Python 3 compatibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/make_global_settings/ld/gyptest-make_global_settings_ld.py

Issue 1454433002: Python 3 compatibility Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: Rebase with master (4ec6c4e3a94bd04a6da2858163d40b2429b8aad1) Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/make_global_settings/ld/gyptest-make_global_settings_ld.py

diff --git a/test/make_global_settings/ld/gyptest-make_global_settings_ld.py b/test/make_global_settings/ld/gyptest-make_global_settings_ld.py

index c5a2e96422a9c18b3d197c7a2485a6cbf5079268..e5f50fbb5bc6640b23601c73099bd4f97f17b734 100644

--- a/test/make_global_settings/ld/gyptest-make_global_settings_ld.py

+++ b/test/make_global_settings/ld/gyptest-make_global_settings_ld.py

@@ -76,7 +76,7 @@ def verify_ld_host(test, ld=None, rel_path=False):

test_format = ['ninja']

-if sys.platform in ('linux2', 'darwin'):

+if sys.platform.startswith('linux') or sys.platform == 'darwin':

test_format += ['make']

test = TestGyp.TestGyp(formats=test_format)