test/linux/gyptest-implicit-rpath.py - Issue 1454433002: Python 3 compatibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/linux/gyptest-implicit-rpath.py

Issue 1454433002: Python 3 compatibility Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: Rebase with master (4ec6c4e3a94bd04a6da2858163d40b2429b8aad1) Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/linux/gyptest-implicit-rpath.py

diff --git a/test/linux/gyptest-implicit-rpath.py b/test/linux/gyptest-implicit-rpath.py

index dd7718c76dbf9209c6cb2fec3a622811abe7230e..055656bbcbe56d606b164f6884c816888010ea1e 100644

--- a/test/linux/gyptest-implicit-rpath.py

+++ b/test/linux/gyptest-implicit-rpath.py

@@ -24,7 +24,8 @@ if sys.platform.startswith('linux'):

def GetRpaths(p):

p = test.built_file_path(p, chdir=CHDIR)

r = re.compile(r'Library rpath: \[([^\]]+)\]')

- proc = subprocess.Popen(['readelf', '-d', p], stdout=subprocess.PIPE)

+ proc = subprocess.Popen(['readelf', '-d', p], stdout=subprocess.PIPE,

+ universal_newlines=True)

o = proc.communicate()[0]

assert not proc.returncode

return r.findall(o)