test/custom-generator/mygenerator.py - Issue 1454433002: Python 3 compatibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/custom-generator/mygenerator.py

Issue 1454433002: Python 3 compatibility Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: Rebase with master (4ec6c4e3a94bd04a6da2858163d40b2429b8aad1) Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/custom-generator/mygenerator.py

diff --git a/test/custom-generator/mygenerator.py b/test/custom-generator/mygenerator.py

index 8eb4c2de1b3a02b332fbbb3d4c873c7549f81754..5fcac3d779178c7c203f821ea9a0d5dfaadb3759 100644

--- a/test/custom-generator/mygenerator.py

+++ b/test/custom-generator/mygenerator.py

@@ -9,6 +9,6 @@ import gyp.common

generator_default_variables = {}

def GenerateOutput(target_list, target_dicts, data, params):

- f = open("MyBuildFile", "wb")

+ f = open("MyBuildFile", "w")

f.write("Testing...\n")

f.close()