test/configurations/target_platform/gyptest-target_platform.py - Issue 1454433002: Python 3 compatibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/configurations/target_platform/gyptest-target_platform.py

Issue 1454433002: Python 3 compatibility Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: Rebase with master (4ec6c4e3a94bd04a6da2858163d40b2429b8aad1) Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/configurations/target_platform/gyptest-target_platform.py

diff --git a/test/configurations/target_platform/gyptest-target_platform.py b/test/configurations/target_platform/gyptest-target_platform.py

index ae4e9e5a2dffe2149b8c31d08f1016a4a99e401b..1645d6ec08e36715306ae4ee9cc9379d516b4266 100755

--- a/test/configurations/target_platform/gyptest-target_platform.py

+++ b/test/configurations/target_platform/gyptest-target_platform.py

@@ -15,7 +15,7 @@ import TestCommon

def RunX64(exe, stdout):

try:

test.run_built_executable(exe, stdout=stdout)

- except WindowsError, e:

+ except WindowsError as e:

# Assume the exe is 64-bit if it can't load on 32-bit systems.

# Both versions of the error are required because different versions

# of python seem to return different errors for invalid exe type.