pylib/gyp/xml_fix.py - Issue 1454433002: Python 3 compatibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pylib/gyp/xml_fix.py

Issue 1454433002: Python 3 compatibility Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: Rebase with master (4ec6c4e3a94bd04a6da2858163d40b2429b8aad1) Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pylib/gyp/xml_fix.py

diff --git a/pylib/gyp/xml_fix.py b/pylib/gyp/xml_fix.py

index 5de848158d28997db6f8558954b194933dad2ad3..4308d99b47c3c6aa37b3ca0e3d1e32bcd057e4c8 100644

--- a/pylib/gyp/xml_fix.py

+++ b/pylib/gyp/xml_fix.py

@@ -32,8 +32,7 @@ def _Replacement_writexml(self, writer, indent="", addindent="", newl=""):

writer.write(indent+"<" + self.tagName)

attrs = self._get_attributes()

- a_names = attrs.keys()

- a_names.sort()

+ a_names = sorted(attrs.keys())

for a_name in a_names:

writer.write(" %s=\"" % a_name)