pylib/gyp/flock_tool.py - Issue 1454433002: Python 3 compatibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pylib/gyp/flock_tool.py

Issue 1454433002: Python 3 compatibility Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: Rebase with master (4ec6c4e3a94bd04a6da2858163d40b2429b8aad1) Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pylib/gyp/flock_tool.py

diff --git a/pylib/gyp/flock_tool.py b/pylib/gyp/flock_tool.py

index b38d8660f728530cae4369ae32f13019f0596604..81fb79d136a0a58ebd7ab80bcda5e974f81b1512 100755

--- a/pylib/gyp/flock_tool.py

+++ b/pylib/gyp/flock_tool.py

@@ -39,7 +39,7 @@ class FlockTool(object):

# where fcntl.flock(fd, LOCK_EX) always fails

# with EBADF, that's why we use this F_SETLK

# hack instead.

- fd = os.open(lockfile, os.O_WRONLY|os.O_NOCTTY|os.O_CREAT, 0666)

+ fd = os.open(lockfile, os.O_WRONLY|os.O_NOCTTY|os.O_CREAT, 0o666)

if sys.platform.startswith('aix'):

# Python on AIX is compiled with LARGEFILE support, which changes the

# struct size.