pylib/gyp/MSVSUtil.py - Issue 1454433002: Python 3 compatibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pylib/gyp/MSVSUtil.py

Issue 1454433002: Python 3 compatibility Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: Rebase with master (4ec6c4e3a94bd04a6da2858163d40b2429b8aad1) Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pylib/gyp/MSVSUtil.py

diff --git a/pylib/gyp/MSVSUtil.py b/pylib/gyp/MSVSUtil.py

index f5e0c1d8b7632a5608793318a3f71fad34a09375..67fa0464e5feebfe9c7f2e8d6bd2742f34b05fc9 100644

--- a/pylib/gyp/MSVSUtil.py

+++ b/pylib/gyp/MSVSUtil.py

@@ -235,7 +235,7 @@ def InsertLargePdbShims(target_list, target_dicts, vars):

# Set up the shim to output its PDB to the same location as the final linker

# target.

- for config_name, config in shim_dict.get('configurations').iteritems():

+ for config_name, config in shim_dict.get('configurations').items():

pdb_path = _GetPdbPath(target_dict, config_name, vars)

# A few keys that we don't want to propagate.