PRESUBMIT.py - Issue 1454433002: Python 3 compatibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 1454433002: Python 3 compatibility Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: Rebase with master (4ec6c4e3a94bd04a6da2858163d40b2429b8aad1) Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index dde025383c327659198c00bb2e1368df24422e90..8180fe5f954b15a0ef886c8126bdde3cd2f10cb0 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -85,7 +85,7 @@ def CheckChangeOnCommit(input_api, output_api):

# Accept any year number from 2009 to the current year.

current_year = int(input_api.time.strftime('%Y'))

- allowed_years = (str(s) for s in reversed(xrange(2009, current_year + 1)))

+ allowed_years = (str(s) for s in reversed(range(2009, current_year + 1)))

years_re = '(' + '|'.join(allowed_years) + ')'

# The (c) is deprecated, but tolerate it until it's removed from all files.

« no previous file with comments | « no previous file | buildbot/buildbot_run.py » ('j') | pylib/gyp/MSVSNew.py » ('J')