Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Side by Side Diff: test/msvs/config_attrs/gyptest-config_attrs.py

Issue 1454433002: Python 3 compatibility Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: Rebase with master (4ec6c4e3a94bd04a6da2858163d40b2429b8aad1) Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 2
3 # Copyright (c) 2012 Google Inc. All rights reserved. 3 # Copyright (c) 2012 Google Inc. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 """ 7 """
8 Verifies that msvs_configuration_attributes and 8 Verifies that msvs_configuration_attributes and
9 msbuild_configuration_attributes are applied by using 9 msbuild_configuration_attributes are applied by using
10 them to set the OutputDirectory. 10 them to set the OutputDirectory.
11 """ 11 """
12 12
13 from __future__ import print_function
14
13 import TestGyp 15 import TestGyp
14 import os 16 import os
15 17
16 import sys 18 import sys
17 19
18 if sys.platform == 'win32': 20 if sys.platform == 'win32':
19 print "This test is currently disabled: https://crbug.com/483696." 21 print("This test is currently disabled: https://crbug.com/483696.")
20 sys.exit(0) 22 sys.exit(0)
21 23
22 24
23 25
24 test = TestGyp.TestGyp(workdir='workarea_all',formats=['msvs']) 26 test = TestGyp.TestGyp(workdir='workarea_all',formats=['msvs'])
25 27
26 vc_version = 'VC90' 28 vc_version = 'VC90'
27 29
28 if os.getenv('GYP_MSVS_VERSION'): 30 if os.getenv('GYP_MSVS_VERSION'):
29 vc_version = ['VC90','VC100'][int(os.getenv('GYP_MSVS_VERSION')) >= 2010] 31 vc_version = ['VC90','VC100'][int(os.getenv('GYP_MSVS_VERSION')) >= 2010]
30 32
31 expected_exe_file = os.path.join(test.workdir, vc_version, 'hello.exe') 33 expected_exe_file = os.path.join(test.workdir, vc_version, 'hello.exe')
32 34
33 test.run_gyp('hello.gyp') 35 test.run_gyp('hello.gyp')
34 36
35 test.build('hello.gyp') 37 test.build('hello.gyp')
36 38
37 test.must_exist(expected_exe_file) 39 test.must_exist(expected_exe_file)
38 40
39 test.pass_test() 41 test.pass_test()
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698