Python 3 compatibility

test/lib/TestGyp.py

 # Copyright (c) 2012 Google Inc. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """
 TestGyp.py:  a testing framework for GYP integration tests.
 """
 
+from __future__ import print_function
+
 import collections
 from contextlib import contextmanager
 import itertools
 import os
 import re
 import shutil
 import subprocess
 import sys
 import tempfile
 
@@ skipping 256 matching lines @@
 
   def report_not_up_to_date(self):
     """
     Reports that a build is not up-to-date.
 
     This provides common reporting for formats that have complicated
     conditions for checking whether a build is up-to-date.  Formats
     that expect exact output from the command (make) can
     just set stdout= when they call the run_build() method.
     """
-    print "Build is not up-to-date:"
-    print self.banner('STDOUT ')
-    print self.stdout()
+    print("Build is not up-to-date:")
+    print(self.banner('STDOUT '))
+    print(self.stdout())
     stderr = self.stderr()
     if stderr:
-      print self.banner('STDERR ')
-      print stderr
+      print(self.banner('STDERR '))
+      print(stderr)
 
   def run_gyp(self, gyp_file, *args, **kw):
     """
     Runs gyp against the specified gyp_file with the specified args.
     """
 
     # When running gyp, and comparing its output we use a comparitor
     # that ignores the line numbers that gyp logs in its debug output.
     if kw.pop('ignore_line_numbers', False):
       kw.setdefault('match', match_modulo_line_numbers)
@@ skipping 17 matching lines @@
 
   def run(self, *args, **kw):
     """
     Executes a program by calling the superclass .run() method.
 
     This exists to provide a common place to filter out keyword
     arguments implemented in this layer, without having to update
     the tool-specific subclasses or clutter the tests themselves
     with platform-specific code.
     """
-    if kw.has_key('SYMROOT'):
+    if 'SYMROOT' in kw:
       del kw['SYMROOT']
     super(TestGypBase, self).run(*args, **kw)
 
   def set_configuration(self, configuration):
     """
     Sets the configuration, to be used for invoking the build
     tool and testing potential built output.
     """
     self.configuration = configuration
 
@@ skipping 209 matching lines @@
     """
     arguments = kw.get('arguments', [])[:]
     if self.configuration:
       arguments.append('BUILDTYPE=' + self.configuration)
     if target not in (None, self.DEFAULT):
       arguments.append(target)
     # Sub-directory builds provide per-gyp Makefiles (i.e.
     # Makefile.gyp_filename), so use that if there is no Makefile.
     chdir = kw.get('chdir', '')
     if not os.path.exists(os.path.join(chdir, 'Makefile')):
-      print "NO Makefile in " + os.path.join(chdir, 'Makefile')
+      print("NO Makefile in " + os.path.join(chdir, 'Makefile'))
       arguments.insert(0, '-f')
       arguments.insert(1, os.path.splitext(gyp_file)[0] + '.Makefile')
     kw['arguments'] = arguments
     return self.run(program=self.build_tool, **kw)
   def up_to_date(self, gyp_file, target=None, **kw):
     """
     Verifies that a build of the specified Make target is up to date.
     """
     if target in (None, self.DEFAULT):
       message_target = 'all'
@@ skipping 86 matching lines @@
   import TestWin
   registry = TestWin.Registry()
 
   msvs_to_msbuild = {
       '2013': r'12.0',
       '2012': r'4.0',  # Really v4.0.30319 which comes with .NET 4.5.
       '2010': r'4.0'}
 
   msbuild_basekey = r'HKLM\SOFTWARE\Microsoft\MSBuild\ToolsVersions'
   if not registry.KeyExists(msbuild_basekey):
-    print 'Error: could not find MSBuild base registry entry'
+    print('Error: could not find MSBuild base registry entry')
     return None
 
   msbuild_version = None
   if msvs_version in msvs_to_msbuild:
     msbuild_test_version = msvs_to_msbuild[msvs_version]
     if registry.KeyExists(msbuild_basekey + '\\' + msbuild_test_version):
       msbuild_version = msbuild_test_version
     else:
       print ('Warning: Environment variable GYP_MSVS_VERSION specifies "%s" '
              'but corresponding MSBuild "%s" was not found.' %
              (msvs_version, msbuild_version))
   if not msbuild_version:
     for msvs_version in sorted(msvs_to_msbuild, reverse=True):
       msbuild_test_version = msvs_to_msbuild[msvs_version]
       if registry.KeyExists(msbuild_basekey + '\\' + msbuild_test_version):
         msbuild_version = msbuild_test_version
         break
   if not msbuild_version:
-    print 'Error: could not find MSBuild registry entry'
+    print('Error: could not find MSBuild registry entry')
     return None
 
   msbuild_path = registry.GetValue(msbuild_basekey + '\\' + msbuild_version,
                                    'MSBuildToolsPath')
   if not msbuild_path:
-    print 'Error: could not get MSBuild registry entry value'
+    print('Error: could not get MSBuild registry entry value')
     return None
 
   return os.path.join(msbuild_path, 'MSBuild.exe')
 
 
 def FindVisualStudioInstallation():
   """Returns appropriate values for .build_tool and .uses_msbuild fields
   of TestGypBase for Visual Studio.
 
   We use the value specified by GYP_MSVS_VERSION.  If not specified, we
@@ skipping 32 matching lines @@
   # Neither GYP_MSVS_VERSION nor the path help us out.  Iterate through
   # the choices looking for a match.
   for version in sorted(possible_paths, reverse=True):
     path = possible_paths[version]
     for r in possible_roots:
       build_tool = os.path.join(r, path)
       if os.path.exists(build_tool):
         uses_msbuild = msvs_version >= '2010'
         msbuild_path = FindMSBuildInstallation(msvs_version)
         return build_tool, uses_msbuild, msbuild_path
-  print 'Error: could not find devenv'
+  print('Error: could not find devenv')
   sys.exit(1)
 
 class TestGypOnMSToolchain(TestGypBase):
   """
   Common subclass for testing generators that target the Microsoft Visual
   Studio toolchain (cl, link, dumpbin, etc.)
   """
   @staticmethod
   def _ComputeVsvarsPath(devenv_path):
     devenv_dir = os.path.split(devenv_path)[0]
@@ skipping 124 matching lines @@
       arguments.extend(['/Project', target])
     if self.configuration:
       arguments.extend(['/ProjectConfig', self.configuration])
     kw['arguments'] = arguments
     return self.run(program=self.build_tool, **kw)
   def up_to_date(self, gyp_file, target=None, **kw):
     """
     Verifies that a build of the specified Visual Studio target is up to date.
 
     Beware that VS2010 will behave strangely if you build under
-    C:\USERS\yourname\AppData\Local. It will cause needless work.  The ouptut
+    C:/USERS/yourname/AppData/Local. It will cause needless work.  The ouptut

[Nico, 2016/07/29 22:22:06]

out of interest, is this needed? with \ it's more convenient to paste into
cmd.exe i suppose

[AWhetter, 2016/11/05 23:59:50]

I've worked around it by making the docstring a raw string instead. So they're
back to being backslashes again.

     will be "1 succeeded and 0 up to date".  MSBuild tracing reveals that:
-    "Project 'C:\Users\...\AppData\Local\...vcxproj' not up to date because
-    'C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 10.0\VC\BIN\1033\CLUI.DLL'
+    "Project 'C:/Users/.../AppData/Local/...vcxproj' not up to date because
+    'C:/PROGRAM FILES (X86)/MICROSOFT VISUAL STUDIO 10.0/VC/BIN/1033/CLUI.DLL'
     was modified at 02/21/2011 17:03:30, which is newer than '' which was
     modified at 01/01/0001 00:00:00.
 
     The workaround is to specify a workdir when instantiating the test, e.g.
     test = TestGyp.TestGyp(workdir='workarea')
     """
     result = self.build(gyp_file, target, **kw)
     if not result:
       stdout = self.stdout()
 
@@ skipping 277 matching lines @@
 ]
 
 def TestGyp(*args, **kw):
   """
   Returns an appropriate TestGyp* instance for a specified GYP format.
   """
   format = kw.pop('format', os.environ.get('TESTGYP_FORMAT'))
   for format_class in format_class_list:
     if format == format_class.format:
       return format_class(*args, **kw)
-  raise Exception, "unknown format %r" % format
+  raise Exception("unknown format %r" % format)