Python 3 compatibility

pylib/gyp/mac_tool.py

 #!/usr/bin/env python
 # Copyright (c) 2012 Google Inc. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Utility functions to perform Xcode-style build steps.
 
 These functions are executed via gyp-mac-tool when using the Makefile generator.
 """
 
+from __future__ import print_function
+
 import fcntl
 import fnmatch
 import glob
 import json
 import os
 import plistlib
 import re
 import shutil
-import string
 import struct
 import subprocess
 import sys
 import tempfile
 
 
 def main(args):
   executor = MacTool()
   exit_code = executor.Dispatch(args)
   if exit_code is not None:
@@ skipping 113 matching lines @@
   def _DetectInputEncoding(self, file_name):
     """Reads the first few bytes from file_name and tries to guess the text
     encoding. Returns None as a guess if it can't detect it."""
     fp = open(file_name, 'rb')
     try:
       header = fp.read(3)
     except e:
       fp.close()
       return None
     fp.close()
-    if header.startswith("\xFE\xFF"):
+    if header.startswith(b"\xFE\xFF"):
       return "UTF-16"
-    elif header.startswith("\xFF\xFE"):
+    elif header.startswith(b"\xFF\xFE"):
       return "UTF-16"
-    elif header.startswith("\xEF\xBB\xBF"):
+    elif header.startswith(b"\xEF\xBB\xBF"):
       return "UTF-8"
     else:
       return None
 
   def ExecCopyInfoPlist(self, source, dest, convert_to_binary, *keys):
     """Copies the |source| Info.plist to the destination directory |dest|."""
     # Read the source Info.plist into memory.
     fd = open(source, 'r')
     lines = fd.read()
     fd.close()
 
     # Insert synthesized key/value pairs (e.g. BuildMachineOSBuild).
     plist = plistlib.readPlistFromString(lines)
     if keys:
-      plist = dict(plist.items() + json.loads(keys[0]).items())
+      plist.update(json.loads(keys[0]))
     lines = plistlib.writePlistToString(plist)
 
     # Go through all the environment variables and replace them as variables in
     # the file.
     IDENT_RE = re.compile(r'[/\s]')
     for key in os.environ:
       if key.startswith('_'):
         continue
       evar = '${%s}' % key
       evalue = os.environ[key]
-      lines = string.replace(lines, evar, evalue)
+      lines = lines.replace(evar, evalue)
 
       # Xcode supports various suffices on environment variables, which are
       # all undocumented. :rfc1034identifier is used in the standard project
       # template these days, and :identifier was used earlier. They are used to
       # convert non-url characters into things that look like valid urls --
       # except that the replacement character for :identifier, '_' isn't valid
       # in a URL either -- oops, hence :rfc1034identifier was born.
       evar = '${%s:identifier}' % key
       evalue = IDENT_RE.sub('_', os.environ[key])
-      lines = string.replace(lines, evar, evalue)
+      lines = lines.replace(evar, evalue)
 
       evar = '${%s:rfc1034identifier}' % key
       evalue = IDENT_RE.sub('-', os.environ[key])
-      lines = string.replace(lines, evar, evalue)
+      lines = lines.replace(evar, evalue)
 
     # Remove any keys with values that haven't been replaced.
     lines = lines.split('\n')
     for i in range(len(lines)):
       if lines[i].strip().startswith("<string>${"):
         lines[i] = None
         lines[i - 1] = None
     lines = '\n'.join(filter(lambda x: x is not None, lines))
 
     # Write out the file with variables replaced.
@@ skipping 50 matching lines @@
     env = os.environ.copy()
     # Ref:
     # http://www.opensource.apple.com/source/cctools/cctools-809/misc/libtool.c
     # The problem with this flag is that it resets the file mtime on the file to
     # epoch=0, e.g. 1970-1-1 or 1969-12-31 depending on timezone.
     env['ZERO_AR_DATE'] = '1'
     libtoolout = subprocess.Popen(cmd_list, stderr=subprocess.PIPE, env=env)
     _, err = libtoolout.communicate()
     for line in err.splitlines():
       if not libtool_re.match(line) and not libtool_re5.match(line):
-        print >>sys.stderr, line
+        print(line, file=sys.stderr)
     # Unconditionally touch the output .a file on the command line if present
     # and the command succeeded. A bit hacky.
     if not libtoolout.returncode:
       for i in range(len(cmd_list) - 1):
         if cmd_list[i] == "-o" and cmd_list[i+1].endswith('.a'):
           os.utime(cmd_list[i+1], None)
           break
     return libtoolout.returncode
 
   def ExecPackageIosFramework(self, framework):
@@ skipping 94 matching lines @@
       ])
     else:
       command_line.extend([
           '--platform', 'macosx', '--target-device', 'mac',
           '--minimum-deployment-target', os.environ['MACOSX_DEPLOYMENT_TARGET'],
           '--compile',
           os.path.abspath(os.environ['UNLOCALIZED_RESOURCES_FOLDER_PATH']),
       ])
     if keys:
       keys = json.loads(keys)
-      for key, value in keys.iteritems():
+      for key, value in keys.items():
         arg_name = '--' + key
         if isinstance(value, bool):
           if value:
             command_line.append(arg_name)
         elif isinstance(value, list):
           for v in value:
             command_line.append(arg_name)
             command_line.append(str(v))
         else:
           command_line.append(arg_name)
@@ skipping 71 matching lines @@
       A tuple of the path to the selected provisioning profile, the data of
       the embedded plist in the provisioning profile and the team identifier
       to use for code signing.
 
     Raises:
       SystemExit: if no .mobileprovision can be used to sign the bundle.
     """
     profiles_dir = os.path.join(
         os.environ['HOME'], 'Library', 'MobileDevice', 'Provisioning Profiles')
     if not os.path.isdir(profiles_dir):
-      print >>sys.stderr, (
-          'cannot find mobile provisioning for %s' % bundle_identifier)
+      print((
+          'cannot find mobile provisioning for %s' % bundle_identifier),
+          file=sys.stderr)
       sys.exit(1)
     provisioning_profiles = None
     if profile:
       profile_path = os.path.join(profiles_dir, profile + '.mobileprovision')
       if os.path.exists(profile_path):
         provisioning_profiles = [profile_path]
     if not provisioning_profiles:
       provisioning_profiles = glob.glob(
           os.path.join(profiles_dir, '*.mobileprovision'))
     valid_provisioning_profiles = {}
     for profile_path in provisioning_profiles:
       profile_data = self._LoadProvisioningProfile(profile_path)
       app_id_pattern = profile_data.get(
           'Entitlements', {}).get('application-identifier', '')
       for team_identifier in profile_data.get('TeamIdentifier', []):
         app_id = '%s.%s' % (team_identifier, bundle_identifier)
         if fnmatch.fnmatch(app_id, app_id_pattern):
           valid_provisioning_profiles[app_id_pattern] = (
               profile_path, profile_data, team_identifier)
     if not valid_provisioning_profiles:
-      print >>sys.stderr, (
-          'cannot find mobile provisioning for %s' % bundle_identifier)
+      print((
+          'cannot find mobile provisioning for %s' % bundle_identifier),
+          file=sys.stderr)
       sys.exit(1)
     # If the user has multiple provisioning profiles installed that can be
     # used for ${bundle_identifier}, pick the most specific one (ie. the
     # provisioning profile whose pattern is the longest).
     selected_key = max(valid_provisioning_profiles, key=lambda v: len(v))
     return valid_provisioning_profiles[selected_key]
 
   def _LoadProvisioningProfile(self, profile_path):
     """Extracts the plist embedded in a provisioning profile.
 
     Args:
       profile_path: string, path to the .mobileprovision file
 
     Returns:
       Content of the plist embedded in the provisioning profile as a dictionary.
     """
     with tempfile.NamedTemporaryFile() as temp:
       subprocess.check_call([
           'security', 'cms', '-D', '-i', profile_path, '-o', temp.name])
       return self._LoadPlistMaybeBinary(temp.name)
 
   def _MergePlist(self, merged_plist, plist):
     """Merge |plist| into |merged_plist|."""
-    for key, value in plist.iteritems():
+    for key, value in plist.items():
       if isinstance(value, dict):
         merged_value = merged_plist.get(key, {})
         if isinstance(merged_value, dict):
           self._MergePlist(merged_value, value)
           merged_plist[key] = merged_value
         else:
           merged_plist[key] = value
       else:
         merged_plist[key] = value
 
@@ skipping 89 matching lines @@
     Args:
       data: object, can be either string, list or dictionary
       substitutions: dictionary, variable substitutions to perform
 
     Returns:
       Copy of data where each references to "$(variable)" has been replaced
       by the corresponding value found in substitutions, or left intact if
       the key was not found.
     """
     if isinstance(data, str):
-      for key, value in substitutions.iteritems():
+      for key, value in substitutions.items():
         data = data.replace('$(%s)' % key, value)
       return data
     if isinstance(data, list):
       return [self._ExpandVariables(v, substitutions) for v in data]
     if isinstance(data, dict):
       return {k: self._ExpandVariables(data[k], substitutions) for k in data}
     return data
 
 def NextGreaterPowerOf2(x):
   return 2**(x-1).bit_length()
@@ skipping 56 matching lines @@
       out.write(struct.pack('<s', '\0'))
       base = os.path.dirname(path) + os.sep
       out.write(struct.pack('<%ds' % len(base), base))
       out.write(struct.pack('<s', '\0'))
       path = os.path.basename(path)
       out.write(struct.pack('<%ds' % len(path), path))
       out.write(struct.pack('<s', '\0'))
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv[1:]))