Python 3 compatibility

pylib/gyp/MSVSSettings_test.py

 #!/usr/bin/env python
 
 # Copyright (c) 2012 Google Inc. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Unit tests for the MSVSSettings.py file."""
 
-import StringIO
+try:
+  from StringIO import StringIO
+except ImportError:
+  from io import StringIO

[Nico, 2016/07/29 22:22:05]

Isn't the recommended pattern "try py3 way, and if that fails fall back to py2"?

[AWhetter, 2016/11/05 23:59:49]

You're right. I've fixed this on my github.

 import unittest
 import gyp.MSVSSettings as MSVSSettings
 
 
 class TestSequenceFunctions(unittest.TestCase):
 
   def setUp(self):
-    self.stderr = StringIO.StringIO()
+    self.stderr = StringIO()
 
   def _ExpectedWarnings(self, expected):
     """Compares recorded lines to expected warnings."""
     self.stderr.seek(0)
     actual = self.stderr.read().split('\n')
     actual = [line for line in actual if line]
     self.assertEqual(sorted(expected), sorted(actual))
 
   def testValidateMSVSSettings_tool_names(self):
     """Tests that only MSVS tool names are allowed."""
@@ skipping 1446 matching lines @@
         }
     actual_msbuild_settings = MSVSSettings.ConvertToMSBuildSettings(
         msvs_settings,
         self.stderr)
     self.assertEqual(expected_msbuild_settings, actual_msbuild_settings)
     self._ExpectedWarnings([])
 
 
 if __name__ == '__main__':
   unittest.main()