Python 3 compatibility

pylib/gyp/MSVSNew.py

 # Copyright (c) 2012 Google Inc. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """New implementation of Visual Studio project generation."""
 
 import os
 import random
 
 import gyp.common
@@ skipping 42 matching lines @@
   d = _new_md5(str(seed) + str(name)).hexdigest().upper()
   # Convert most of the signature to GUID form (discard the rest)
   guid = ('{' + d[:8] + '-' + d[8:12] + '-' + d[12:16] + '-' + d[16:20]
           + '-' + d[20:32] + '}')
   return guid
 
 #------------------------------------------------------------------------------
 
 
 class MSVSSolutionEntry(object):
-  def __cmp__(self, other):
-    # Sort by name then guid (so things are in order on vs2008).
-    return cmp((self.name, self.get_guid()), (other.name, other.get_guid()))
+  # Sort by name then guid (so things are in order on vs2008).
+  def __lt__(self, other):

[Nico, 2016/07/29 22:22:05]

This looks like an unfortunate change :-/

[AWhetter, 2016/11/05 23:59:49]

It is really. I could make it slighty easier on the eyes and do something like
add a _cmp method that takes an operator as an argument, and __lt__, __gt__, etc
call that with an operator.

+    return (self.name, self.get_guid()) < (other.name, other.get_guid())
+
+  def __gt__(self, other):
+    return (self.name, self.get_guid()) > (other.name, other.get_guid())
+
+  def __eq__(self, other):
+    return (self.name, self.get_guid()) == (other.name, other.get_guid())
+
+  def __le__(self, other):
+    return (self.name, self.get_guid()) <= (other.name, other.get_guid())
+
+  def __ge__(self, other):
+    return (self.name, self.get_guid()) >= (other.name, other.get_guid())
+
+  def __ne__(self, other):
+    return (self.name, self.get_guid()) != (other.name, other.get_guid())
 
 
 class MSVSFolder(MSVSSolutionEntry):
   """Folder in a Visual Studio project or solution."""
 
   def __init__(self, path, name = None, entries = None,
                guid = None, items = None):
     """Initializes the folder.
 
     Args:
@@ skipping 255 matching lines @@
       for e in all_entries:
         if not isinstance(e, MSVSFolder):
           continue        # Does not apply to projects, only folders
         for subentry in e.entries:
           f.write('\t\t%s = %s\r\n' % (subentry.get_guid(), e.get_guid()))
       f.write('\tEndGlobalSection\r\n')
 
     f.write('EndGlobal\r\n')
 
     f.close()