Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: media/cast/video_sender/video_sender_unittest.cc

Issue 145443005: Fixes for memory and threading issues in cast (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix compile Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/cast/video_sender/video_sender.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/video_sender/video_sender_unittest.cc
diff --git a/media/cast/video_sender/video_sender_unittest.cc b/media/cast/video_sender/video_sender_unittest.cc
index 40111f9b0c75db2d09f11fa69fec523379236309..0acd7be93fafda1fcd9a906f2ea15eb7bc637d03 100644
--- a/media/cast/video_sender/video_sender_unittest.cc
+++ b/media/cast/video_sender/video_sender_unittest.cc
@@ -82,15 +82,17 @@ class PeerVideoSender : public VideoSender {
class VideoSenderTest : public ::testing::Test {
protected:
VideoSenderTest() {
- testing_clock_.Advance(
+ testing_clock_ = new base::SimpleTestTickClock();
+ testing_clock_->Advance(
base::TimeDelta::FromMilliseconds(kStartMillisecond));
- task_runner_ = new test::FakeTaskRunner(&testing_clock_);
+ task_runner_ = new test::FakeTaskRunner(testing_clock_);
cast_environment_ = new CastEnvironment(
- &testing_clock_, task_runner_, task_runner_, task_runner_, task_runner_,
+ scoped_ptr<base::TickClock>(testing_clock_).Pass(),
+ task_runner_, task_runner_, task_runner_, task_runner_,
task_runner_, task_runner_, GetDefaultCastSenderLoggingConfig());
transport::CastTransportConfig transport_config;
transport_sender_.reset(new transport::CastTransportSenderImpl(
- &testing_clock_, transport_config,
+ testing_clock_, transport_config,
base::Bind(&UpdateCastTransportStatus), task_runner_));
transport_sender_->InsertFakeTransportForTesting(&transport_);
}
@@ -141,12 +143,12 @@ class VideoSenderTest : public ::testing::Test {
void RunTasks(int during_ms) {
for (int i = 0; i < during_ms; ++i) {
// Call process the timers every 1 ms.
- testing_clock_.Advance(base::TimeDelta::FromMilliseconds(1));
+ testing_clock_->Advance(base::TimeDelta::FromMilliseconds(1));
task_runner_->RunTasks();
}
}
- base::SimpleTestTickClock testing_clock_;
+ base::SimpleTestTickClock* testing_clock_; // Owned by CastEnvironment.
TestPacketSender transport_;
scoped_ptr<transport::CastTransportSenderImpl> transport_sender_;
scoped_refptr<test::FakeTaskRunner> task_runner_;
@@ -231,4 +233,3 @@ TEST_F(VideoSenderTest, ResendTimer) {
} // namespace cast
} // namespace media
-
« no previous file with comments | « media/cast/video_sender/video_sender.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698