Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 145443004: Resolve a few memory leaks in tests. (Closed)

Created:
6 years, 11 months ago by hal.canary
Modified:
6 years, 11 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Resolve a few memory leaks in tests. Purge the global scaled image cache after use in tests. The cache was right to hold on to the pixels indefinitely, but this change makes it easier to run down actual memory leaks. Add SK_DECLARE_INST_COUNT to several classes. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13171

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M include/core/SkMallocPixelRef.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/SkGrPixelRef.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/core/SkScaledImageCache.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/lazy/SkCachingPixelRef.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/lazy/SkDiscardablePixelRef.h View 1 chunk +1 line, -0 lines 0 comments Download
M tests/CachedDecodingPixelRefTest.cpp View 3 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hal.canary
ptal
6 years, 11 months ago (2014-01-23 19:05:13 UTC) #1
reed1
lgtm
6 years, 11 months ago (2014-01-24 17:17:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/145443004/1
6 years, 11 months ago (2014-01-24 18:21:18 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-24 18:33:26 UTC) #4
Message was sent while issue was closed.
Change committed as 13171

Powered by Google App Engine
This is Rietveld 408576698