Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1454423003: WebRTC: Remove video_engine_core_unittests (Closed)

Created:
5 years, 1 month ago by kjellander_chromium
Modified:
5 years, 1 month ago
Reviewers:
phoglund_chromium, pbos
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org, pbos
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

WebRTC: Remove video_engine_core_unittests This test is being merged into video_engine_tests in https://codereview.webrtc.org/1409803007/ BUG=webrtc:1695 TBR=phoglund@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297616

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+308 lines, -2742 lines) Patch
M scripts/slave/recipe_modules/webrtc/api.py View 2 chunks +0 lines, -3 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5_.json View 1 chunk +0 lines, -22 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5__dbg_.json View 1 chunk +0 lines, -21 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5__failing_test.json View 2 chunks +1 line, -23 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5__forced.json View 1 chunk +0 lines, -22 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus7_2_.json View 1 chunk +0 lines, -22 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus7_2__dbg_.json View 1 chunk +0 lines, -21 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64_tests__l_nexus9_.json View 1 chunk +0 lines, -22 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_asan__l_nexus6_.json View 1 chunk +0 lines, -23 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_tests__l_nexus6__dbg_.json View 1 chunk +0 lines, -21 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux64_release__swarming_.json View 4 chunks +1 line, -137 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux_ubsan.json View 1 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux_ubsan_vptr.json View 1 1 chunk +0 lines, -26 lines 0 comments Download
A + scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_mac32_debug__xcode_7_.json View 1 16 chunks +47 lines, -72 lines 0 comments Download
A + scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_mac32_release__xcode_7_.json View 1 16 chunks +47 lines, -72 lines 0 comments Download
A + scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_mac64_debug__xcode_7_.json View 1 17 chunks +50 lines, -75 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_mac64_release__swarming_.json View 4 chunks +1 line, -137 lines 0 comments Download
A + scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_mac64_release__xcode_7_.json View 1 17 chunks +50 lines, -75 lines 0 comments Download
A + scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_mac_asan__xcode_7_.json View 1 16 chunks +47 lines, -73 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win32_release__swarming_.json View 4 chunks +1 line, -137 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_debug.json View 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_release.json View 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug.json View 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug_failing_test.json View 2 chunks +1 line, -27 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug_forced.json View 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release.json View 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_asan.json View 1 chunk +0 lines, -28 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_memcheck.json View 1 chunk +0 lines, -32 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_msan.json View 1 chunk +0 lines, -27 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_tsan_v2.json View 1 chunk +0 lines, -27 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac32_debug.json View 1 chunk +0 lines, -25 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac32_release.json View 1 chunk +0 lines, -25 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_debug.json View 1 chunk +0 lines, -25 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_release.json View 1 chunk +0 lines, -25 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac_asan.json View 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_debug.json View 1 chunk +0 lines, -25 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release.json View 1 chunk +0 lines, -25 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug.json View 1 chunk +0 lines, -25 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release.json View 1 chunk +0 lines, -25 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win_drmemory_full.json View 1 chunk +0 lines, -31 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win_drmemory_light.json View 1 chunk +0 lines, -31 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win_syzyasan.json View 1 chunk +0 lines, -25 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_arm64_rel.json View 1 chunk +0 lines, -22 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_dbg.json View 1 chunk +0 lines, -21 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_n6.json View 1 chunk +0 lines, -21 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_rel.json View 1 1 chunk +0 lines, -22 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_asan.json View 1 chunk +0 lines, -27 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_dbg.json View 1 chunk +0 lines, -25 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_dbg_legacy_svn_patch.json View 1 chunk +0 lines, -25 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_memcheck.json View 1 chunk +0 lines, -31 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_msan.json View 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_rel.json View 1 chunk +0 lines, -25 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_swarming.json View 4 chunks +1 line, -137 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_tsan2.json View 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan.json View 1 1 chunk +0 lines, -25 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan_vptr.json View 1 1 chunk +0 lines, -25 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_asan.json View 1 chunk +0 lines, -25 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_dbg.json View 1 chunk +0 lines, -24 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_rel.json View 1 chunk +0 lines, -24 lines 0 comments Download
A + scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_rel_xcode7.json View 1 20 chunks +59 lines, -95 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_swarming.json View 4 chunks +1 line, -137 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_x64_dbg.json View 1 chunk +0 lines, -24 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_x64_rel.json View 1 chunk +0 lines, -24 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_asan.json View 1 chunk +0 lines, -24 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_dbg.json View 1 chunk +0 lines, -24 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_drmemory_full.json View 1 chunk +0 lines, -30 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_drmemory_light.json View 1 chunk +0 lines, -30 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_rel.json View 1 chunk +0 lines, -24 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_swarming.json View 4 chunks +1 line, -137 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_dbg.json View 1 chunk +0 lines, -24 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_rel.json View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
kjellander_chromium
5 years, 1 month ago (2015-11-19 14:24:43 UTC) #3
pbos
lgtm for the .py, rs-lgtm for the json
5 years, 1 month ago (2015-11-19 14:25:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1454423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1454423003/1
5 years, 1 month ago (2015-11-19 14:48:50 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: build_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/build_presubmit/builds/3116)
5 years, 1 month ago (2015-11-19 14:50:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1454423003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1454423003/20001
5 years, 1 month ago (2015-11-19 14:52:42 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=297616
5 years, 1 month ago (2015-11-19 14:55:25 UTC) #14
kjellander_chromium
5 years, 1 month ago (2015-11-19 16:13:00 UTC) #15
Message was sent while issue was closed. 
On 2015/11/19 14:55:25, commit-bot: I haz the power wrote:
> Committed patchset #2 (id:20001) as
> http://src.chromium.org/viewvc/chrome?view=rev&revision=297616

*sigh*, I ran the expectation training with a filter argument for this CL, which
ended up with me readding the xcode7 expectation files.
I'm fixing that in https://codereview.chromium.org/1455283003/ now.

Powered by Google App Engine
This is Rietveld 408576698