Add msaa configs to bench_pictures

Add msaa configs to bench_pictures.

Enables msaa4 and msaa16 configs in bench_pictures and render_pictures (and anything else that may use PictureRenderer).

[bsalomon, 2013-04-29 18:59:26]

Adding scroggo@ who might know something about this code (unlike me).

https://codereview.chromium.org/14544007/diff/1/tools/PictureRenderer.h
File tools/PictureRenderer.h (right):

https://codereview.chromium.org/14544007/diff/1/tools/PictureRenderer.h#newco...
tools/PictureRenderer.h:210: if (fSampleCount == 4) {
if (fSampleCount) {
    config.appendf("_msaa%d", fSampleCount);
} else {
    config.append("_gpu");
}

[scroggo, 2013-04-29 19:05:44]

lgtm

https://codereview.chromium.org/14544007/diff/1/tools/PictureRenderer.h
File tools/PictureRenderer.h (right):

https://codereview.chromium.org/14544007/diff/1/tools/PictureRenderer.h#newco...
tools/PictureRenderer.h:331: int                    fSampleCount;
Should this be an enum that only accepts 4, 16, and 0?

[jvanverth1, 2013-04-29 19:36:27]

https://codereview.chromium.org/14544007/diff/1/tools/PictureRenderer.h
File tools/PictureRenderer.h (right):

https://codereview.chromium.org/14544007/diff/1/tools/PictureRenderer.h#newco...
tools/PictureRenderer.h:210: if (fSampleCount == 4) {
On 2013/04/29 18:59:26, bsalomon wrote:
> if (fSampleCount) {
>     config.appendf("_msaa%d", fSampleCount);
> } else {
>     config.append("_gpu");
> }

Done.

https://codereview.chromium.org/14544007/diff/1/tools/PictureRenderer.h#newco...
tools/PictureRenderer.h:331: int                    fSampleCount;
On 2013/04/29 19:05:44, scroggo wrote:
> Should this be an enum that only accepts 4, 16, and 0?

Done.

[bsalomon, 2013-04-29 19:46:54]

On 2013/04/29 19:36:27, JimVV wrote:
> https://codereview.chromium.org/14544007/diff/1/tools/PictureRenderer.h
> File tools/PictureRenderer.h (right):
> 
>
https://codereview.chromium.org/14544007/diff/1/tools/PictureRenderer.h#newco...
> tools/PictureRenderer.h:210: if (fSampleCount == 4) {
> On 2013/04/29 18:59:26, bsalomon wrote:
> > if (fSampleCount) {
> >     config.appendf("_msaa%d", fSampleCount);
> > } else {
> >     config.append("_gpu");
> > }
> 
> Done.
> 
>
https://codereview.chromium.org/14544007/diff/1/tools/PictureRenderer.h#newco...
> tools/PictureRenderer.h:331: int                    fSampleCount;
> On 2013/04/29 19:05:44, scroggo wrote:
> > Should this be an enum that only accepts 4, 16, and 0?
> 
> Done.

I'm assuming that scroggo@ suggested the enum as an alternative to concat my
suggestion for appendf. Seems unnecessarily restrictive to have the enum IMO.

[scroggo, 2013-04-29 19:52:24]

On 2013/04/29 19:46:54, bsalomon wrote:
> On 2013/04/29 19:36:27, JimVV wrote:
> > https://codereview.chromium.org/14544007/diff/1/tools/PictureRenderer.h
> > File tools/PictureRenderer.h (right):
> > 
> >
>
https://codereview.chromium.org/14544007/diff/1/tools/PictureRenderer.h#newco...
> > tools/PictureRenderer.h:210: if (fSampleCount == 4) {
> > On 2013/04/29 18:59:26, bsalomon wrote:
> > > if (fSampleCount) {
> > >     config.appendf("_msaa%d", fSampleCount);
> > > } else {
> > >     config.append("_gpu");
> > > }
> > 
> > Done.
> > 
> >
>
https://codereview.chromium.org/14544007/diff/1/tools/PictureRenderer.h#newco...
> > tools/PictureRenderer.h:331: int                    fSampleCount;
> > On 2013/04/29 19:05:44, scroggo wrote:
> > > Should this be an enum that only accepts 4, 16, and 0?
> > 
> > Done.
> 
> I'm assuming that scroggo@ suggested the enum as an alternative to concat my
> suggestion for appendf. Seems unnecessarily restrictive to have the enum IMO.

lgtm, with or without the enum.

[jvanverth1, 2013-04-29 20:09:20]

On 2013/04/29 19:52:24, scroggo wrote:
> On 2013/04/29 19:46:54, bsalomon wrote:
> > On 2013/04/29 19:36:27, JimVV wrote:
> > > https://codereview.chromium.org/14544007/diff/1/tools/PictureRenderer.h
> > > File tools/PictureRenderer.h (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/14544007/diff/1/tools/PictureRenderer.h#newco...
> > > tools/PictureRenderer.h:210: if (fSampleCount == 4) {
> > > On 2013/04/29 18:59:26, bsalomon wrote:
> > > > if (fSampleCount) {
> > > >     config.appendf("_msaa%d", fSampleCount);
> > > > } else {
> > > >     config.append("_gpu");
> > > > }
> > > 
> > > Done.
> > > 
> > >
> >
>
https://codereview.chromium.org/14544007/diff/1/tools/PictureRenderer.h#newco...
> > > tools/PictureRenderer.h:331: int                    fSampleCount;
> > > On 2013/04/29 19:05:44, scroggo wrote:
> > > > Should this be an enum that only accepts 4, 16, and 0?
> > > 
> > > Done.
> > 
> > I'm assuming that scroggo@ suggested the enum as an alternative to concat my
> > suggestion for appendf. Seems unnecessarily restrictive to have the enum
IMO.
> 
> lgtm, with or without the enum.

Enum is now gone.

[scroggo, 2013-04-29 20:11:02]

lgtm

[bsalomon, 2013-04-30 14:21:17]

lgtm

[commit-bot: I haz the power, 2013-05-02 12:29:18]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/jvanverth@google.com/14544007/2007