Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1454363002: Close tooltip for |title| attribute on any keyboard event. (Closed)

Created:
5 years, 1 month ago by tkent
Modified:
5 years, 1 month ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Close tooltip for |title| attribute on any keyboard event. The new behavior is reasonable because tooltips can disturb text editing with keyboards, and is compatible with Firefox. BUG=557660 TEST=automated Committed: https://crrev.com/ba5314a45b489366dba21342d26dc6572412cbe3 Cr-Commit-Position: refs/heads/master@{#360555}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix DOCTYPE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/html/tooltip-close.html View 1 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
tkent
yosin@, would you review this please?
5 years, 1 month ago (2015-11-19 06:42:33 UTC) #2
yosin_UTC9
lgtm Could you add TEST=LayoutTests/fast/html/tooltip-close.html in description, just in case? https://codereview.chromium.org/1454363002/diff/1/third_party/WebKit/LayoutTests/fast/html/tooltip-close.html File third_party/WebKit/LayoutTests/fast/html/tooltip-close.html (right): https://codereview.chromium.org/1454363002/diff/1/third_party/WebKit/LayoutTests/fast/html/tooltip-close.html#newcode1 ...
5 years, 1 month ago (2015-11-19 07:31:44 UTC) #3
tkent
https://codereview.chromium.org/1454363002/diff/1/third_party/WebKit/LayoutTests/fast/html/tooltip-close.html File third_party/WebKit/LayoutTests/fast/html/tooltip-close.html (right): https://codereview.chromium.org/1454363002/diff/1/third_party/WebKit/LayoutTests/fast/html/tooltip-close.html#newcode1 third_party/WebKit/LayoutTests/fast/html/tooltip-close.html:1: <!DOCTYPE> On 2015/11/19 at 07:31:44, Yosi_UTC9 wrote: > Q: ...
5 years, 1 month ago (2015-11-19 07:36:39 UTC) #4
tkent
> Could you add TEST=LayoutTests/fast/html/tooltip-close.html in description, just in case? TEST= is not a field ...
5 years, 1 month ago (2015-11-19 07:42:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1454363002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1454363002/20001
5 years, 1 month ago (2015-11-19 07:44:12 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-19 10:41:57 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 10:43:50 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ba5314a45b489366dba21342d26dc6572412cbe3
Cr-Commit-Position: refs/heads/master@{#360555}

Powered by Google App Engine
This is Rietveld 408576698