Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: components/cronet/url_request_context_config.cc

Issue 1454333002: Revert of [Cronet] Add QUIC experimental params (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@experiment_ops
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cronet/run_all_unittests.cc ('k') | components/cronet/url_request_context_config_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/url_request_context_config.cc
diff --git a/components/cronet/url_request_context_config.cc b/components/cronet/url_request_context_config.cc
index ef94d0d89ca66831f883193f1a983adfb551ba54..5cd24b8664120160a03325b4288a9fd4b1c68752 100644
--- a/components/cronet/url_request_context_config.cc
+++ b/components/cronet/url_request_context_config.cc
@@ -22,12 +22,6 @@
// TODO(xunjieli): Refactor constants in io_thread.cc.
const char kQuicFieldTrialName[] = "QUIC";
const char kQuicConnectionOptions[] = "connection_options";
-const char kQuicStoreServerConfigsInProperties[] =
- "store_server_configs_in_properties";
-const char kQuicDelayTcpRace[] = "delay_tcp_race";
-const char kQuicMaxNumberOfLossyConnections[] =
- "max_number_of_lossy_connections";
-const char kQuicPacketLossThreshold[] = "packet_loss_threshold";
// Using a reference to scoped_ptr is unavoidable because of the semantics of
// RegisterCustomField.
@@ -47,7 +41,6 @@
if (experimental_options.empty())
return;
- DVLOG(1) << "Experimental Options:" << experimental_options;
scoped_ptr<base::Value> options =
base::JSONReader::Read(experimental_options);
@@ -73,32 +66,6 @@
&quic_connection_options)) {
context_builder->set_quic_connection_options(
net::QuicUtils::ParseQuicConnectionOptions(quic_connection_options));
- }
-
- bool quic_store_server_configs_in_properties = false;
- if (quic_args->GetBoolean(kQuicStoreServerConfigsInProperties,
- &quic_store_server_configs_in_properties)) {
- context_builder->set_quic_store_server_configs_in_properties(
- quic_store_server_configs_in_properties);
- }
-
- bool quic_delay_tcp_race = false;
- if (quic_args->GetBoolean(kQuicDelayTcpRace, &quic_delay_tcp_race)) {
- context_builder->set_quic_delay_tcp_race(quic_delay_tcp_race);
- }
-
- int quic_max_number_of_lossy_connections = 0;
- if (quic_args->GetInteger(kQuicMaxNumberOfLossyConnections,
- &quic_max_number_of_lossy_connections)) {
- context_builder->set_quic_max_number_of_lossy_connections(
- quic_max_number_of_lossy_connections);
- }
-
- double quic_packet_loss_threshold = 0.0;
- if (quic_args->GetDouble(kQuicPacketLossThreshold,
- &quic_packet_loss_threshold)) {
- context_builder->set_quic_packet_loss_threshold(
- quic_packet_loss_threshold);
}
}
}
« no previous file with comments | « components/cronet/run_all_unittests.cc ('k') | components/cronet/url_request_context_config_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698